From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75282A0C47; Thu, 14 Oct 2021 13:20:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F2FE4112E; Thu, 14 Oct 2021 13:20:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id F40AF40041 for ; Thu, 14 Oct 2021 13:20:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634210451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uSQ1q0QE34hWl9+1tBnMnYMkSU3fM1ibQPTwtSGX6fU=; b=gY3c1tf69BlD4NZK26tYvwUF4f45BxLX8KFcDm6K5k/BT/r3h+Z9Res6FPIpC8KTPXoEPC 9IxaEdvplW73sUKI5k0QTGZe97QA1zXSUyhGAyJQzr5Jwi+M+DKe+tm+BI5h4Bw7aqBOXA pQVUTrsRmRYTYlI8p+C+EbnyFINPZY0= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-Op8wBrcyN_eGizy8QLNEoQ-1; Thu, 14 Oct 2021 07:20:50 -0400 X-MC-Unique: Op8wBrcyN_eGizy8QLNEoQ-1 Received: by mail-lf1-f72.google.com with SMTP id bu34-20020a05651216a200b003fd7bb9caa1so4177493lfb.0 for ; Thu, 14 Oct 2021 04:20:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uSQ1q0QE34hWl9+1tBnMnYMkSU3fM1ibQPTwtSGX6fU=; b=sDjNH9xjY//Kr4Wf1Zghst2bdsQINF6UB5kX3I/GCkbDVJcZW9mBcgkBwgFZF+3RoW lrKklgM0PnY1sZ39IfsXmiV44q3KSVAM418c8RAL8phEEpK2gXbIPlwIcyFQhdhM1dG9 H9ekov9LMwoSyaT8ji97xCY5B5uyBNV0cbqaftdF4gkkCYBsUXaqaU+rYtBbfyFvlju1 kfZ2YlKLiJRt3CbEBnYnwFRdrdIDO1KlPMdtfgJ+I8A93cn2K3cWZNI0Wz8UarBWiMiX jKKdSX0NoYX96M86RGqFHFjGa2+f/Ip5H3vLRDL/ESGWC92M8l7kWpVt1RS+/bTRDrzE TBdQ== X-Gm-Message-State: AOAM530EE5nRywIEyX88RxpVexS3BEvZedPTCDhsG0rLbnQkrSlycYp7 Tn8JknB2NfdWkrmAE+vtxyLC1ZThA5+LmEs0DUeiLZkGnGSuzhFtYLaUp7kH1ZLHaGDpfDJLRrs c+5W4tA7oSqhk0BeTdf4= X-Received: by 2002:a2e:9018:: with SMTP id h24mr3616993ljg.477.1634210448637; Thu, 14 Oct 2021 04:20:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynQ1ixS4tkiY4MxLJJ8T4cDrgOEKVLN2UQJ2UeRp91qI773xFgj27xqrqO//Moi/1MC2WhiV+ZKfzn+Sbm8TM= X-Received: by 2002:a2e:9018:: with SMTP id h24mr3616962ljg.477.1634210448333; Thu, 14 Oct 2021 04:20:48 -0700 (PDT) MIME-Version: 1.0 References: <20211014085026.2991677-1-dkozlyuk@nvidia.com> <20211014085528.2992805-1-dkozlyuk@nvidia.com> In-Reply-To: <20211014085528.2992805-1-dkozlyuk@nvidia.com> From: David Marchand Date: Thu, 14 Oct 2021 13:20:37 +0200 Message-ID: To: Dmitry Kozlyuk Cc: dev , Raslan Darawsheh , Xueming Li , dpdk stable , Harman Kalra , Thomas Monjalon , Matan Azrad , Viacheslav Ovsiienko Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 14, 2021 at 10:55 AM Dmitry Kozlyuk wrote: > > MLX5 PMD exposes a socket for external tools to dump port state. > Socket events are listened using an interrupt source of EXT type. > The socket was closed and the interrupt callback was unregistered > at program exit, which is incorrect because DPDK could be already > shut down at this point. Move actions performed at program exit > to the moment the last MLX5 port is closed. The socket will be opened > again if later a new MLX5 device is plugged in and probed. > Also fix comments that were deceisively talking > about secondary processes instead of external tools. +1 for fixing those comments. > > Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools") > Cc: Xueming Li > Cc: stable@dpdk.org > > Reported-by: Harman Kalra > Signed-off-by: Dmitry Kozlyuk > Acked-by: Thomas Monjalon The fix lgtm, thanks. There is a separate issue I spotted while reviewing. I'll send a separate fix. -- David Marchand