From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71D7243728; Wed, 20 Dec 2023 16:42:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A49740685; Wed, 20 Dec 2023 16:42:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 572B840291 for ; Wed, 20 Dec 2023 16:42:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703086937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cI21+jdVX0W9ex2mJE2HLVyO78uEHh6xVPg9EC0UoXI=; b=g4CHFs2VMnNfQWuQqhDCr51+52EpeJihBPWTMxNzuJqTgZMx0v4zZ7/XG8Ma+HHDUcEY8U YmO6AIx8vQjioUlQEpgEa3RYkCuRPv1pHvwEgFIX7EEg/clTrcLWPJuoZ65SdC7Yzuzz+W +oIncVmseSK5YxvzOGIZqJD2Xh7VMSs= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-0V4LabjTOdSL1hOZgIXHHQ-1; Wed, 20 Dec 2023 10:42:15 -0500 X-MC-Unique: 0V4LabjTOdSL1hOZgIXHHQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2cc83b19edeso15956021fa.1 for ; Wed, 20 Dec 2023 07:42:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703086934; x=1703691734; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cI21+jdVX0W9ex2mJE2HLVyO78uEHh6xVPg9EC0UoXI=; b=h4BWNcVoDyA0kUWScByd660RQUCkEnSGeqIxglWY4oC9T9BKL4mMIMh5Us3DLg/nnH jsgJ7K8jqLugtMQGdhcsgr7CsaVqb/hQffyNCUErp2U9MQiZbWAqysqNEnelUuB6VSoh aM3SIdEfmBhOAv3YkrLLYPpqNJW+B3VMCf03Og1EJz7Cs+Q0V4o2qqHLRmI6tWUvNV3h 7Ckzj2dp5qpmijguP3hGIyfss69FX8wUyPnGfWAEYIWpyvVmUz6tPJ3CfX5hiADc/GW/ RaLf2qCxxkpMKhNeh8zXYpu5476awokv9TNJuIiKbJuIgb3mzs0XtaXtGsjxnCLNCiQw uP+g== X-Gm-Message-State: AOJu0YxfXW/+D1+tx0ll8oJGXKsKOFTUGCXtwdK14e8JTmmwAD5DSykp ThGOjqx6YGORG/ZRn/AgswWIOjVbEDtaXDXmwJEf9V9UW7ArnV1enuvCK/Zh8E55BtvXLYFVOsw KXmfiIHqHBGM6lxObCMFC1i1qyIc= X-Received: by 2002:a05:6512:3287:b0:50e:54b7:824a with SMTP id p7-20020a056512328700b0050e54b7824amr551537lfe.76.1703086934083; Wed, 20 Dec 2023 07:42:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/4y3jXxAYypBjO8di896CzGUEnGZOZGryHgtJItAko2W7dYHbt8OEqn3cM1RuujXLUppglcZ5eRRWBbf+s7k= X-Received: by 2002:a05:6512:3287:b0:50e:54b7:824a with SMTP id p7-20020a056512328700b0050e54b7824amr551527lfe.76.1703086933753; Wed, 20 Dec 2023 07:42:13 -0800 (PST) MIME-Version: 1.0 References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231220153607.718606-1-david.marchand@redhat.com> <20231220153607.718606-12-david.marchand@redhat.com> In-Reply-To: <20231220153607.718606-12-david.marchand@redhat.com> From: David Marchand Date: Wed, 20 Dec 2023 16:42:02 +0100 Message-ID: Subject: Re: [PATCH v5 11/13] log: add a per line log helper To: dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, Chengwen Feng X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 20, 2023 at 4:39=E2=80=AFPM David Marchand wrote: > > gcc builtin __builtin_strchr can be used as a static assertion to check > whether passed format strings contain a \n. > This can be useful to detect double \n in log messages. > > Signed-off-by: David Marchand > Acked-by: Stephen Hemminger > Acked-by: Chengwen Feng > --- > Changes since v4: > - fixed build with -pedantic, Unfortunately, upon testing, clang does not support constant expression folding in (Ubuntu 20.04 and Fedora 37 at least) older versions. So we may manage to make this check work with clang, but that's for the fut= ure. --=20 David Marchand