From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60E88A04BC; Fri, 9 Oct 2020 11:02:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B8AA1C206; Fri, 9 Oct 2020 11:02:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id C9CCD1C202 for ; Fri, 9 Oct 2020 11:02:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602234150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YdaFrSU0FhCXlr2O3ypPn26uuicNtrMe6gNgmqDeD+E=; b=jMuKqzmfxF7QZ2Q1+NTQAEPutbfdwEamIWA2NYlSrH96aKwnGu99cr2Mx5ydcHfylbiLj8 eRUF3kN3auRYsJ2bsgB5fszerqbe1H0hzIC4z9aaSuo7+Y/7Bg6IMo1dDMnkKfDrZxnp0y rppQqjWI/3yEfv/OMypItblHDGpPzSc= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-96-AuNC8dDVO2ydi6cO__6Vmw-1; Fri, 09 Oct 2020 05:02:26 -0400 X-MC-Unique: AuNC8dDVO2ydi6cO__6Vmw-1 Received: by mail-ua1-f72.google.com with SMTP id m11so2247940uah.6 for ; Fri, 09 Oct 2020 02:02:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YdaFrSU0FhCXlr2O3ypPn26uuicNtrMe6gNgmqDeD+E=; b=kzPNn74OhQO99v+phTPX4heVlohH7zzFXXNUIVDVOwwdPBPyljbF6aQRbjFXvnuzTV 02I0jCISrQNr5FQ//aFQ9IxZOK6sc7XDNe6VK1tlp3x5Zt7Pa0mrE6+yoJlVO8ju0zn1 LkQNfMjQNlW+nHVN4olu5PKuTum+wGfMA9PxCy7dG3/GeDqI8k8nWQDGR2URDFl1A/Qu EgOHS5G7gwGey75HtPZNx7iAJZvKDaVv3u2UEy4hoc6Dvx7Yu/gqazLpmRbUIWjOYKvi BWYorOS2w3WXZYsh79revTi9MVNzRTa84Y+SVX/JYkrhrrsqGb8c/eHCJRDrt2MHL4V4 103w== X-Gm-Message-State: AOAM5312FdsGR+G8t6BEiHJp9cvmjFDFuH3nhltRgpY+s2lC9H3t73Vv vWsRD4Grmh7/EUCJozgxMmiwugYenrDLLL9j5JvHUU2XIAr2sn2rF1rumeIPBTs5VyMfJiwcKLf XAyNJmoDXDBo1JnKvrRY= X-Received: by 2002:ab0:5926:: with SMTP id n35mr6669148uad.126.1602234146078; Fri, 09 Oct 2020 02:02:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwswtvML3Ka7+SpnOKBs/aq2bDpGM1vgx+47we6BR5pehPmV3C+Xb5w7NdQ2Ne/Cla4KYXjSVkh0YMb2nT2Z8k= X-Received: by 2002:ab0:5926:: with SMTP id n35mr6669142uad.126.1602234145862; Fri, 09 Oct 2020 02:02:25 -0700 (PDT) MIME-Version: 1.0 References: <20201007214848.249516-1-thomas@monjalon.net> In-Reply-To: From: David Marchand Date: Fri, 9 Oct 2020 11:02:15 +0200 Message-ID: To: "Pattan, Reshma" Cc: "Power, Ciara" , "Yigit, Ferruh" , Thomas Monjalon , "dev@dpdk.org" , "Van Haaren, Harry" , "Laatz, Kevin" , "arybchenko@solarflare.com" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 9, 2020 at 10:36 AM Pattan, Reshma wrote: > > >> +* ethdev: Renamed basic statistics per queue. An underscore is > > >> +inserted > > >> + between the queue number and the rest of the xstat name: > > >> + > > >> + * ``rx_qN*`` -> ``rx_qN_*`` > > >> + * ``tx_qN*`` -> ``tx_qN_*`` > > >> + > > > > > >As far as I remember collect plugin was using xstat output, does this > > >rename affects it? Or any other telemetry application relying on xstats. > > > > > >Harry, Ciara, Kevin, do you know anything that will be affected from rename? > > > > I don't think this change will affect anything with telemetry itself, but I am not > > so familiar with the CollectD plugin, Reshma may be able to verify that. > > Neither collectd has any dependency on naming. I am not sure about this statement. collectd dpdkstats plugin does seem to inspect the names. And I can see what looks like a workaround on the problem Thomas is fixing here. https://github.com/collectd/collectd/commit/126b35ee8786a3aca1bcc1346a60bc528d06c414 Can you test Thomas patch? -- David Marchand