From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C5AFA0577; Mon, 6 Apr 2020 22:16:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F05432B96; Mon, 6 Apr 2020 22:16:21 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 484882B86 for ; Mon, 6 Apr 2020 22:16:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586204179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M5Nbz/0n8MKrk6yQUMDf2m5wdYOWZ52xQucBGaI4Dro=; b=dlQXh5/sJjK/uqxtDUa2LykF9UOnKLrh2Mb2RsCgzVoLWpEXJTuuv1nHyvi8Lo8kTCk5t2 hrsE7XujWJfiplcjYynpsIuNbIJ7MHgYfXPmyi2H5Z6e4Av5wz2FbnZhyFXzJ/KlmGDPKQ S55U3tCKXz+Ou1xKpfRLExdHGa88n6k= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-kfYGQlXBM0SrE6h2EO40nw-1; Mon, 06 Apr 2020 16:16:14 -0400 X-MC-Unique: kfYGQlXBM0SrE6h2EO40nw-1 Received: by mail-ua1-f72.google.com with SMTP id 14so266276ual.20 for ; Mon, 06 Apr 2020 13:16:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ptiyyTQZgnII8tAJ9ksvnwMB5fmZu1dK0dHHeCAtoFw=; b=Tx4EpNB8AScG7oOQc4MjOnjHKIegnYqbnYriQAZ1dJ7rCFrra1jprGH3t1caSJ/XfY 1AvHaC9HMygaCWKLN6AXgxyAjCM/X9jC82O/fgUcblCDo6c4TDLIgAIpWeYEDbvw66RF x+hFBCd25trgV5Z1iTOpzxkTfNjBL8PaWovIpoxHQM9aJj+fHSpm9e66sQR/yV7Hj8yq +nakgVFy6oYKGB0DNp8wuTMyknFhJoW4fN7jAsDAKHbjo4D3S23ZGftbtvGYE4dfQC7X Ah1gjdFkj8cHuqNI/gH9YmLWKLUyqKR+GEQ97puHSsw07vz5ZZK8wpGP10Rsoilji079 XKoA== X-Gm-Message-State: AGi0PuaBfN+LoNubwtzD9lPqjTLA8+lruQyd4vs4cR9pvp9FObUJs82u kEeOB/hvSh4wvRJ08jfRyqCW5knSGy2wUlfV2sqoghHFqlYiKBI6wbDi3L79C7S4sT6Uz2/XWMp Do/YnO20CgzamR6qtpPM= X-Received: by 2002:a67:26c2:: with SMTP id m185mr1300994vsm.180.1586204173637; Mon, 06 Apr 2020 13:16:13 -0700 (PDT) X-Google-Smtp-Source: APiQypKw1Lo+dmlHUAg4NzFxPgxmlWn6i6In2p6Vnc+WS+1hc+X4z5Ve1rjsmZh/g7zkk9I6Ky6mJyl7JgfSVKP1b0M= X-Received: by 2002:a67:26c2:: with SMTP id m185mr1300974vsm.180.1586204173358; Mon, 06 Apr 2020 13:16:13 -0700 (PDT) MIME-Version: 1.0 References: <20200402183253.866-1-jerinjacobk@gmail.com> <20200403141921.10275-1-pbhagavatula@marvell.com> In-Reply-To: <20200403141921.10275-1-pbhagavatula@marvell.com> From: David Marchand Date: Mon, 6 Apr 2020 22:16:02 +0200 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob Kollanukkaran , Thomas Monjalon , "Yigit, Ferruh" , Bruce Richardson , Neil Horman , Kevin Laatz , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3] build: enable allow experimental API flag globally X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 3, 2020 at 4:20 PM wrote: > Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and > meson.build in app, lib and drivers instead enable ALLOW_EXPERIMENTAL_API > flag globally. This change does not enable the flag globally. > This changes reduces the clutter across the project while still maintaini= ng > the functionality of ALLOW_EXPERIMENTAL_API i.e. warning external > applications about experimental API usage. > > Signed-off-by: Pavan Nikhilesh > Acked-by: Hemant Agrawal [snip] > diff --git a/app/meson.build b/app/meson.build > index 71109cc42..7e9193fc3 100644 > --- a/app/meson.build > +++ b/app/meson.build > @@ -26,7 +26,6 @@ default_cflags =3D machine_args > foreach app:apps > build =3D true > name =3D app > - allow_experimental_apis =3D false > sources =3D [] > includes =3D [] > cflags =3D default_cflags > @@ -53,10 +52,7 @@ foreach app:apps > link_libs =3D dpdk_static_libraries + dpdk_driver= s > endif > > - if allow_experimental_apis > - cflags +=3D '-DALLOW_EXPERIMENTAL_API' > - endif > - > + cflags +=3D '-DALLOW_EXPERIMENTAL_API' > executable('dpdk-' + name, > sources, > c_args: cflags, Please apply the same logic in app/ than for drivers/. This will spare us the special app/test/meson.build thing, which can be removed too. [snip] > diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_note= s/release_20_05.rst > index 000bbf501..9059f9563 100644 > --- a/doc/guides/rel_notes/release_20_05.rst > +++ b/doc/guides/rel_notes/release_20_05.rst > @@ -62,6 +62,12 @@ New Features > > * Added support for matching on IPv4 Time To Live and IPv6 Hop Limit. > > +* **Enable ALLOW_EXPERIMENTAL_API flag globally.** > + > + Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile a= nd > + meson.build in app, lib and drivers instead enable ALLOW_EXPERIMENTAL_= API > + flag globally. > + Reading this and the sections we have, it does not fit here. This is not a new feature. This change only affects DPDK contributors, so let's just drop the release notes update. > > Removed Items > ------------- [snip] > diff --git a/lib/meson.build b/lib/meson.build > index 9c3cc55d5..3bf14fcdf 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -47,7 +47,6 @@ foreach l:libraries > build =3D true > reason =3D '' # set if build =3D=3D false to expl= ain why > name =3D l > - allow_experimental_apis =3D false > use_function_versioning =3D false > sources =3D [] > headers =3D [] > @@ -98,9 +97,7 @@ foreach l:libraries > static_dep =3D shared_dep > else > > - if allow_experimental_apis > - cflags +=3D '-DALLOW_EXPERIMENTAL_API' > - endif > + cflags +=3D '-DALLOW_EXPERIMENTAL_API' > if use_function_versioning > cflags +=3D '-DRTE_USE_FUNCTION_VERSIONIN= G' > endif Ditto, apply same logic than drivers/meson.build Thanks. --=20 David Marchand