From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60D4045EED; Thu, 19 Dec 2024 16:37:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 017DA40265; Thu, 19 Dec 2024 16:37:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 299DC4025F for ; Thu, 19 Dec 2024 16:37:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734622673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AyVoEbCEpu3Rb0uS8rzMw7w71+GCUovb8sZtp9hGfQw=; b=AfbC3DUf/38of1qL84uTh+1EjNjgyoCWKoLw0nQgLjZq1du3x39Z5Fivw2j92AXtSzfEqe iIL/tzj6FKDMjfmdQT1TECJW7wspSPFPk2JgILiQojRzxm2HxWmCYTJvsjwfDGr8mOGORP IoxOD+76V6L71KJQo6/UvwLkfZuQCpY= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-bxfmYgpGMZug4Drt2BGKTg-1; Thu, 19 Dec 2024 10:37:52 -0500 X-MC-Unique: bxfmYgpGMZug4Drt2BGKTg-1 X-Mimecast-MFC-AGG-ID: bxfmYgpGMZug4Drt2BGKTg Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-53e16ec0fa6so393861e87.2 for ; Thu, 19 Dec 2024 07:37:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734622671; x=1735227471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AyVoEbCEpu3Rb0uS8rzMw7w71+GCUovb8sZtp9hGfQw=; b=JvQt/t245yhO2Tsz9D/CLqk/jE2feZD2ss2Has9S7mfiqzJS3zXnycpquW//HZFFGj FoF7ZSUC4Z00kLjHc6tkhA/yaFxBnHxu3NTOZOszwIBI5A5iy/1XptyvjkTA4Am5hk3O 9RSGU+2BNekl8kSqWxKqsumDZrCz8k0h8Z3q3t3lO5CgPPDeG7AKI+YXZH+heUPPGsrM fdckru9U47/RTOlIWBL2SnoZ4pjUx0qQoweVpGrXFLZcpKgJWXWQHoQO/4cQuPvzh5lo PQLO1TVnanp/p7q3zrSMf83GFxtOiNhbRZa3qAy0FUEQYsZtSDWhwDa4GUlxqs9kvzTH AYKA== X-Gm-Message-State: AOJu0YwnGWLMjpRpqudsacVN99gIATl3BzRRpiwA8OpArkLNsLlPVExY S1pcJq4MVuOu4WEqM41+6sHF6jBIEbfMzO16XeQVxzGjPXQ/uotMyPaJjGt0or3JOopSIqZ9P8C kKeStlGvlYitfXdem88k1Ldx6DrlVrst3RYffVPf0Pc6cNOSP9ziI0C+R3GM2xt54jXiYLG7MAq edcom1mG3/BcQiq+g= X-Gm-Gg: ASbGncuNvP3UnmByLqpBMe53cKtCMB8OL8t71rgxGe3dBKDyvTAY/ts2opSgfsEkq0r KWzf0TW/PnezkibKr5tA2Qd/OWD3/wZWfQbVseyx4 X-Received: by 2002:a05:6512:ba4:b0:541:21f9:45b6 with SMTP id 2adb3069b0e04-541ed8f73a3mr2391169e87.37.1734622670959; Thu, 19 Dec 2024 07:37:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IHo6aYHml8EKJVR2T5zgKpttmGYTtPd8PLRz0fjdSp/BUFoG9oEMckXxCSt/Wwgk3YoKUH2Dq6sv6siKUaqQdk= X-Received: by 2002:a05:6512:ba4:b0:541:21f9:45b6 with SMTP id 2adb3069b0e04-541ed8f73a3mr2391163e87.37.1734622670566; Thu, 19 Dec 2024 07:37:50 -0800 (PST) MIME-Version: 1.0 References: <20241219133139.420001-1-thomas@monjalon.net> In-Reply-To: <20241219133139.420001-1-thomas@monjalon.net> From: David Marchand Date: Thu, 19 Dec 2024 16:37:39 +0100 Message-ID: Subject: Re: [PATCH v2] cryptodev: fix C++ include To: Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org, Zhigang Hu , Akhil Goyal , Fan Zhang , =?UTF-8?Q?Morten_Br=C3=B8rup?= , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cLQ7QL_gy6OByvHb_qDqNf4NRLPtxDlhOKYIirwnV8Q_1734622671 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 19, 2024 at 2:31=E2=80=AFPM Thomas Monjalon wrote: > > Some cryptodev functions were not included in an extern "C" block. > > There are 2 blocks, the second one being fast path inline functions, > preceded with an include of the required rte_cryptodev_core.h file. > > Fixes: 719834a6849e ("use C linkage where appropriate in headers") > Cc: stable@dpdk.org > > Reported-by: Zhigang Hu > Signed-off-by: Thomas Monjalon I wonder if there is also an issue with lib/cryptodev/rte_crypto_asym.h, for symbols rte_crypto_asym_ke_strings and rte_crypto_asym_op_strings. But at least this patch looks fine to me. Reviewed-by: David Marchand --=20 David Marchand