From: David Marchand <david.marchand@redhat.com>
To: lhx <li.hanxiao@zte.com.cn>
Cc: dev@dpdk.org, Akhil Goyal <gakhil@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] zsda:introduce zsda drivers and examples
Date: Tue, 2 Jul 2024 10:52:58 +0200 [thread overview]
Message-ID: <CAJFAV8xM3J3izkrCfj+cD8+6QxrqGLW=WkFhcfBqe=+w7sWhLA@mail.gmail.com> (raw)
In-Reply-To: <20240701082751.3479106-1-li.hanxiao@zte.com.cn>
Hello,
Thanks for the submission.
On Tue, Jul 2, 2024 at 10:42 AM lhx <li.hanxiao@zte.com.cn> wrote:
>
> From: = Hanxiao Li <li.hanxiao@zte.com.cn>
There is an extra = sign here, please remove.
>
> Introduce zsda (ZTE Storage Data Accelerator) drivers and examples,
> which can help to accelerate some calculation process.
It looks like this is an upstreaming effort for code written against
DPDK v21.11.
There are unrelated / broken changes (probably due to some rebase issue).
Please fix at least what I quickly noticed:
- no version.map if unneeded,
- no touching of rte_config.h like disabling RTE_BACKTRACE,
- don't reintroduce renamed headers, like for example rte_cryptodev_pmd.h,
- don't remove "dma" device support in usertools/dpdk-devbind.py,
- don't introduce a hardware specific example,
Important: overall, this patch should be split in logical smaller
patches introducing feature one at a time.
And for next revisions, please version your patches, and register to
the dev@ mailing list and patchwork.
--
David Marchand
next prev parent reply other threads:[~2024-07-02 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 8:27 lhx
2024-07-02 8:52 ` David Marchand [this message]
2024-07-02 13:11 ` [EXTERNAL] " Akhil Goyal
-- strict thread matches above, loose matches on Subject: below --
2024-06-28 9:17 [PATCH] zsda: introduce " lhx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xM3J3izkrCfj+cD8+6QxrqGLW=WkFhcfBqe=+w7sWhLA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=li.hanxiao@zte.com.cn \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).