From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ECBE45B12; Fri, 11 Oct 2024 14:47:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3505402A3; Fri, 11 Oct 2024 14:47:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C2228402A1 for ; Fri, 11 Oct 2024 14:47:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728650823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DVrg0AZm3ozelsn8dyJBrqqZmS750pyMvwRAsSfvfa0=; b=LXcBEtUfBRzdt9VAgAisZsLWoqnXS1hBvgqviAvt8ZZ3Qd6un+ohUYNfZpO3hQrVP/GUlw sIL01AhffA1raEuz0oBxcrl2PHlhjH44xCskw2nlTtE1iQSPw9igZS8zIW1OdE/9zfrF52 sFjyTvb4YbX7gwSS7imnb2o4jp29FYw= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-wgfpeQeXOiS_V6iDDn7LWw-1; Fri, 11 Oct 2024 08:47:02 -0400 X-MC-Unique: wgfpeQeXOiS_V6iDDn7LWw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-539a078aaf2so2033290e87.1 for ; Fri, 11 Oct 2024 05:47:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728650821; x=1729255621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DVrg0AZm3ozelsn8dyJBrqqZmS750pyMvwRAsSfvfa0=; b=QZeJ4+5ZZeqLMTwijCfmYScVs61wvpCXFROfomwOnNk65moGqrt8Swta2srcxZbsjQ q7rnd8FrbtcdX09V/At7SEbsZEBPkXbWFngGZPT11VuTA+6lR4+kFQavXoWXIF2OsCcl 14SOF6LwZrrA8/1hnA4P4qUHy7pOmxWEDxZU7Yf9IsqLU70f1H8UfnuJxOgeM8Fr4INV 3HmDyrLYBz2PO7Tdi1DPJA4+vv7rpKZA92nlFiHyqbfgMBoGek2REla0zDi2ymPGn+UW 9pCKLfGZHXlAeaqFKLBmGyUt4+JmcIfHNz96Pq08r6aym0A0+0JIGi8y1cnpOdBLhd58 nQiA== X-Gm-Message-State: AOJu0YwepyAAIOZhZiftJnF6XUQghciIt5ObnyfHtrH8aWQLVcntl5H/ x1fOsigjItQ3VcqLHqsFhcH3WAny31IF0gDp09sR4P5h6AuiecYabc3XYFmt+6XbYMXGDyuK4SC eZH6bq7oIqdQOdJK5eAIh7ZyNVLoz68N/YT13p77BbE5E/lVYm1h0UHPWEd6KzP9VcrWIjs83ug gVwVAin3PDU8xpubE= X-Received: by 2002:ac2:4e10:0:b0:536:55cf:3148 with SMTP id 2adb3069b0e04-539da4e16b1mr1623295e87.31.1728650820673; Fri, 11 Oct 2024 05:47:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXOcEKKqUI7Hbf5qWmIm6LMwzNowbefd5jtzQg9G0j8KCY7BqGz22aS0YZpAc64vEkYccF32Z98FCQO/JkDvw= X-Received: by 2002:ac2:4e10:0:b0:536:55cf:3148 with SMTP id 2adb3069b0e04-539da4e16b1mr1623278e87.31.1728650820222; Fri, 11 Oct 2024 05:47:00 -0700 (PDT) MIME-Version: 1.0 References: <20240301104129.3725-1-laitianli@tom.com> <20241003221051.34924-1-stephen@networkplumber.org> In-Reply-To: <20241003221051.34924-1-stephen@networkplumber.org> From: David Marchand Date: Fri, 11 Oct 2024 14:46:49 +0200 Message-ID: Subject: Re: [PATCH] app/dumpcap: fix handling of jumbo frames To: Stephen Hemminger Cc: dev@dpdk.org, Tianli Lai X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 4, 2024 at 12:11=E2=80=AFAM Stephen Hemminger wrote: > > If dumpcap (in legacy pcap mode) tried to handle a large segmented > frame it would core dump because rte_pktmbuf_read() would return NULL. > Fix by using same logic as in pcap PMD. > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Cc: stable@dpdk.org > Reported-by: Tianli Lai > Signed-off-by: Stephen Hemminger Applied, thanks. --=20 David Marchand