From: David Marchand <david.marchand@redhat.com>
To: dev <dev@dpdk.org>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
Owen Hilyard <ohilyard@iol.unh.edu>,
dpdk stable <stable@dpdk.org>, Qi Zhang <qi.z.zhang@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] ipc: stop mp control thread on cleanup
Date: Thu, 8 Jul 2021 11:54:41 +0200 [thread overview]
Message-ID: <CAJFAV8xMtiNhKx5t+KDMAEJvW3JZHiCyEmoxi__Fp4MS6Wf6ng@mail.gmail.com> (raw)
In-Reply-To: <a72ae392-a7ef-18c2-125b-d25f0b0afbe3@redhat.com>
On Thu, Jul 8, 2021 at 9:23 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
> On 7/7/21 1:02 PM, David Marchand wrote:
> > When calling rte_eal_cleanup, the mp channel cleanup routine only sets
> > mp_fd to -1 leaving the rte_mp_handle control thread running.
> > This control thread can spew warnings on reading on an invalid fd.
> > This is especially noticed with ASAN enabled.
> >
> > To handle this situation, set mp_fd to -1 to signal the control thread
> > it should exit, but since this thread might be sleeping on the socket,
> > cancel the thread too.
> >
> > Fixes: 85d6815fa6d0 ("eal: close multi-process socket during cleanup")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Owen Hilyard <ohilyard@iol.unh.edu>
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2021-07-08 9:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 9:12 [dpdk-dev] [PATCH] " David Marchand
2021-06-16 8:34 ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-07-07 11:02 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-07-08 7:23 ` Maxime Coquelin
2021-07-08 9:54 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xMtiNhKx5t+KDMAEJvW3JZHiCyEmoxi__Fp4MS6Wf6ng@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=ohilyard@iol.unh.edu \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).