From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6053FA0C4A; Thu, 8 Jul 2021 11:55:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A04BE415B8; Thu, 8 Jul 2021 11:54:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id C5598410DF for ; Thu, 8 Jul 2021 11:54:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625738096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0Kc2PI/5XRZ80NzDFmzXyafAP352PWuKLrZzmWSmKYo=; b=OmNwFpPCSpH705mlLIs6FQMgXsdWXQlF7afmDGWIqXDpZKPDb+HIKRazimgy0AjLInHY8D O0t7YnQzIZh8BNnrQkcUuhZUS/2PrggYixKjXJpt2n2W+CAURAkK7UoZRHzdw3pbxbf+Or ETx/96CJwYrbs4+3/feY4lW0gBZe+G4= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-eaihaZdmPAaAQQ3paw4x4A-1; Thu, 08 Jul 2021 05:54:53 -0400 X-MC-Unique: eaihaZdmPAaAQQ3paw4x4A-1 Received: by mail-ua1-f69.google.com with SMTP id i8-20020a9f3b080000b029023c932e01b8so2196800uah.3 for ; Thu, 08 Jul 2021 02:54:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Kc2PI/5XRZ80NzDFmzXyafAP352PWuKLrZzmWSmKYo=; b=t0RWTDwlQGxzdYAtqUjc8okbBuOyAY4nNhGjBjcEuc8qqB9z01rD4O02kcRKIV535f kN4p2h+mxlFMYqVeSVwsvt8my3IQg6KtatOdzUhRsKYc/UT3zOw4JuGPVGsmdZAQf7rm GN87p7w2eUhJFOnNK50dcwkBANbdfaZtYgdDqXNf5e3De44ej2tTc1mgrxwZZjYlKGq8 CHTd5bTdnGWdf80ksqoPn96Dmucsp2b1VRRzUXnbQdoyw6ZHstxMRTSyoIzMHMy2NrHJ KWBfnQuqqJaloJdn8SUujyZQoXHh6A1pnveVuq172fGCMM6hM/j7MjQmtATzqNEu+ug4 w2Aw== X-Gm-Message-State: AOAM532xY3DjTIDaBwcW3AiD/8Lidyy6YOHh7nRCRzW1jdPYVdt6uyE6 aFi4VxxJnfSgS5VXaGW+L1ssIFQFFkm22ty8yEdsv9MOMrxbCJtnrmeKknhndrWYZM8ijwVyKy7 F7WLJFNAvn1ZiUL/GyJ4= X-Received: by 2002:a05:6102:3196:: with SMTP id c22mr19469526vsh.27.1625738093200; Thu, 08 Jul 2021 02:54:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxm/lTW6iZhQ1s1LKhZRaz5YdYF81RUxdtwT4R4cbk+/vCFNAWN0JNKfCAR8Fk7hlUvKSmTvRoV1ngMQDJk8tQ= X-Received: by 2002:a05:6102:3196:: with SMTP id c22mr19469511vsh.27.1625738092963; Thu, 08 Jul 2021 02:54:52 -0700 (PDT) MIME-Version: 1.0 References: <20210614091213.3953-1-david.marchand@redhat.com> <20210707110230.8695-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 8 Jul 2021 11:54:41 +0200 Message-ID: To: dev Cc: "Burakov, Anatoly" , Owen Hilyard , dpdk stable , Qi Zhang , Maxime Coquelin Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] ipc: stop mp control thread on cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 8, 2021 at 9:23 AM Maxime Coquelin wrote: > On 7/7/21 1:02 PM, David Marchand wrote: > > When calling rte_eal_cleanup, the mp channel cleanup routine only sets > > mp_fd to -1 leaving the rte_mp_handle control thread running. > > This control thread can spew warnings on reading on an invalid fd. > > This is especially noticed with ASAN enabled. > > > > To handle this situation, set mp_fd to -1 to signal the control thread > > it should exit, but since this thread might be sleeping on the socket, > > cancel the thread too. > > > > Fixes: 85d6815fa6d0 ("eal: close multi-process socket during cleanup") > > Cc: stable@dpdk.org > > > > Reported-by: Owen Hilyard > > Signed-off-by: David Marchand > Reviewed-by: Maxime Coquelin Applied, thanks. -- David Marchand