From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F35B45EC1; Mon, 16 Dec 2024 17:07:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBA954025F; Mon, 16 Dec 2024 17:07:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 89AAD40144 for ; Mon, 16 Dec 2024 17:06:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734365218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fy+3k7ZxY2agBDcosvk9yyiu3SDPhh2mGJ8BFo3WClY=; b=V5Gj7rvgHjAH/rGmVgFjV8hQG1/RhMlnh78ZBmDTIDtwN/SAGs6KPqKhnb6uwIE4RciGSO EAqjre7QaC1kkKgA9LWSHBVpybj43ltcQmJ7H8G5SHtzxaJ/Y0odPpJcuIoSjW4jzEJBe7 OaYH3+PYD1NAHszmo7C1OzAvcZzENZQ= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-gYRvpjMYPlOOsjiEvWSa9Q-1; Mon, 16 Dec 2024 11:06:57 -0500 X-MC-Unique: gYRvpjMYPlOOsjiEvWSa9Q-1 X-Mimecast-MFC-AGG-ID: gYRvpjMYPlOOsjiEvWSa9Q Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-3021da9e8b4so28039021fa.1 for ; Mon, 16 Dec 2024 08:06:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734365216; x=1734970016; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fy+3k7ZxY2agBDcosvk9yyiu3SDPhh2mGJ8BFo3WClY=; b=sR2I5JGyyUURyo6KgBjnRud/NetyWH0Q07bDe34BlZsZh2Qkj6yE54JVFGJSkHLtGx cgI09M6IHmVoc3AeOENF1DYF5q139DOjvRx+yo86oi0Ztxscy2YI3AMPPhEKtPcEtRs9 Ivf0ypMyvG1QMaUR46s7A96+CZon0loJgbJmBLenbeBBt/5dnserJ1Zb6U0ZmEc7ZhiQ A6Mbmbm1tKd+0Q404klKeSOepEE1QRJsdYBr6qd8xSszS1w/knbGIsCk53wZerhzPS9Q urBVvYrcrzazW/NfijH/mnNqhjaitKQVgGeD8IaN2h1mFTZmlHic5HAijoRj7iQyl+gR uQcg== X-Gm-Message-State: AOJu0YwzhJkq/4Uqpb07VmNjpwUCUR7M2o1eK/CHK4unmneg61xX4Hv8 I8Hgc+pawXZyTHJ1XddPMoT7vltoICE8P+Kvv9q9Kr5ZoPR3P37uj8hlsr0juDJpZtSAtpEfagD zWKp1CgLRNkZC1wghp/rSkqTXSoWnx3e7bXsp21iqHGtV1IiZbYq5AYKwd5O15q86Uj9aNYYf7E OvsJRHamp5RaP0S7I= X-Gm-Gg: ASbGnctq6CcsmA+MfKaMW/ph5SgVR95hIyjZw1A//USuq5IFMS3XzMKr1TTAbRxLwT7 LrnyGxXbvDoLH2ftHUxm5JB9Fo15pMsZSKRgAtOAQ X-Received: by 2002:a05:651c:1a0b:b0:302:1e65:f2ab with SMTP id 38308e7fff4ca-302544ca738mr39850121fa.20.1734365215876; Mon, 16 Dec 2024 08:06:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEb/Zvj4x2eCEvJ8jV7OKxf307FzGmfhMQe+0kuKDMq8m911sHrrGzoYQOh6jqkxt8K9aOyTGJroxz3P6m8i+c= X-Received: by 2002:a05:651c:1a0b:b0:302:1e65:f2ab with SMTP id 38308e7fff4ca-302544ca738mr39849981fa.20.1734365215376; Mon, 16 Dec 2024 08:06:55 -0800 (PST) MIME-Version: 1.0 References: <8791f24718116e4a51e7e0be350a5a405ef4f455.1732719309.git.anatoly.burakov@intel.com> <29bb264f-a9b1-4061-b6fc-06b72f193958@intel.com> In-Reply-To: <29bb264f-a9b1-4061-b6fc-06b72f193958@intel.com> From: David Marchand Date: Mon, 16 Dec 2024 17:06:44 +0100 Message-ID: Subject: Re: [PATCH v5 6/8] build: reduce driver dependencies To: "Burakov, Anatoly" Cc: dev@dpdk.org, Nicolas Chautru , Gagandeep Singh , Hemant Agrawal , Parav Pandit , Xueming Li , Sachin Saxena , Rosen Xu , Chenbo Xia , Nipun Gupta , Tomasz Duszynski , Chengwen Feng , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra , Anoob Joseph , Jingjing Wu , Praveen Shetty , Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Kai Ji , Fan Zhang , Ashish Gupta , Nagadheeraj Rottela , Ajit Khaparde , Vikas Gupta , Ankur Dwivedi , Tejasree Kondoj , Pablo de Lara , Srikanth Jampala , Vamsi Attunuru , Gowrishankar Muthukrishnan , Vidya Sagar Velumuri , Kevin Laatz , Bruce Richardson , Pavan Nikhilesh , Shijith Thotton , Pravin Pathak , Jerin Jacob , Harry van Haaren , Ashwin Sekhar T K , Srikanth Yalavarthi , Vladimir Medvedkin , Ian Stokes , Long Li , Wei Hu , Andrew Rybchenko , Cristian Dumitrescu , Maxime Coquelin , Jakub Palider , Yong Zhang , Liron Himi , Vijay Kumar Srivastava X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Bc_hdNNIBNQIGxnbsNIedFy7eiDT55BYsW4lradKVrI_1734365216 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 27, 2024 at 5:20=E2=80=AFPM Burakov, Anatoly wrote: > > On 11/27/2024 3:56 PM, Anatoly Burakov wrote: > > From: Bruce Richardson > > > > Remove any unnecessary dependencies from the driver dependency lists. > > This will give each driver a near-minimum set of required dependencies. > > > > Signed-off-by: Bruce Richardson > > Reviewed-by: Rosen Xu > > --- > > > > diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.= build > > index 5a8de16fe0..5ffb56fc93 100644 > > --- a/drivers/common/qat/meson.build > > +++ b/drivers/common/qat/meson.build > > @@ -71,7 +71,7 @@ else > > endif > > endif > > > > -deps +=3D ['bus_pci', 'cryptodev', 'net', 'compressdev'] > > +deps +=3D ['bus_pci'] > > sources +=3D files( > > 'qat_common.c', > > 'qat_qp.c', > > @@ -101,6 +101,7 @@ if qat_compress > > ] > > sources +=3D files(join_paths(qat_compress_relpath, f)) > > endforeach > > + deps +=3D ['compressdev'] > > endif > > > > if qat_crypto > > Seems that these changes were overly aggressive and cause build > failures. Will fix in v6. Indeed, some crypto-related headers still get included in "common" code. --=20 David Marchand