From: David Marchand <david.marchand@redhat.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev <dev@dpdk.org>, Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH] mempool: clarify default populate function
Date: Thu, 17 Oct 2019 07:00:55 +0200 [thread overview]
Message-ID: <CAJFAV8xN-GLgok7q6NE5ku4vv6XEJnLjBnJtWO9185VXW1e=rw@mail.gmail.com> (raw)
In-Reply-To: <20191008093405.23533-1-olivier.matz@6wind.com>
On Tue, Oct 8, 2019 at 11:35 AM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> No functional change. Clarify the populate function to make
> the next commit easier to understand.
After discussion offlist, changed this:
Clarify the populate function to make future changes easier to
understand.
>
> Rename the variables:
> - to avoid negation in the name
> - to have more understandable names
>
> Remove useless variable (no_pageshift is equivalent to pg_sz == 0).
>
> Remove duplicate affectation of "external" variable.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2019-10-17 5:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:34 Olivier Matz
2019-10-17 5:00 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xN-GLgok7q6NE5ku4vv6XEJnLjBnJtWO9185VXW1e=rw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).