From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9891CA3168 for ; Thu, 17 Oct 2019 07:01:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6DDF51E4ED; Thu, 17 Oct 2019 07:01:10 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id BEB8C1DFF1 for ; Thu, 17 Oct 2019 07:01:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571288468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KlBCvv9kvKYJ730lHzJg1CDdQuRwsp1Dt11X5okOLs0=; b=APAXQxOrMyXGpmIEeoR35QYC90zExWWkBMf0wfI3zZT0ytchPCyZ6NVn0aaAvhPVtbPq13 qu1mEgHOq7VoAcpzWFqtAGmn67bDd969tEnm6N5jf1lEUfRVoJhhJpwX6jFfYSq6ftW+Em 3S0SYKdvS2HJq0ZwvFnpjGjLd6L/l6I= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-O_LBfYrjP9uZUl4vrwL_Cg-1; Thu, 17 Oct 2019 01:01:06 -0400 Received: by mail-vk1-f197.google.com with SMTP id n124so483025vkg.13 for ; Wed, 16 Oct 2019 22:01:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yUZChZXarXaiwCemC8GQTFWAqE7eAa3PuiEXjvYNlNA=; b=NBacFAjjk1s+8np0XTC8KT6jwG65rCqPf5SU+F/y56vtYS/XjoOiRz+2du51S8FnJf EKJHNPVNMsG9GU/G2AnG9ZkEpRCrPb51/fj3QvTDaK7edtR09s60XY+BxCOCqiSFlRmt JR4kO5gUZbPtjueOXGGGVMPvIsu/MfXP2T974e7oSQxqPVsoX6cqtpx0ptYXnU1hC3Ug 89VwChI6mIcMJtK8EZPjCpp7DnL58ZQ6uOBSxvAAIOomPEbNAp8UVW51p+k/kwFm0e/3 ecizNWvvBVSLYtFQf2DdZdjVLHrLKsnXf3HjAHEp8EIq5I4jkb2EZFJiu+nTatImtOiy FwEg== X-Gm-Message-State: APjAAAUg/rmISUFttWNcgrVWbRi8vXhb7G7wH6G5aXyYwWL6/sss0G9v 4xMKh38KsAggWRwiZjWlyAUcfjQgz+L3kt/vXCihb2S3O/+oHJ28pHRlokf3LCe3a0kX+lorjxZ MeMPboBVOijoIKAgKGL4= X-Received: by 2002:a67:fc49:: with SMTP id p9mr851777vsq.198.1571288466204; Wed, 16 Oct 2019 22:01:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqx2cjvVbGLqGx5/iqw+IR0dn2BssjmSZs8G6thxsNnvxocUGFV0f+Sb+tyXoUCEWlIbgkuICtMm9Yb6h43AJD0= X-Received: by 2002:a67:fc49:: with SMTP id p9mr851759vsq.198.1571288465984; Wed, 16 Oct 2019 22:01:05 -0700 (PDT) MIME-Version: 1.0 References: <20191008093405.23533-1-olivier.matz@6wind.com> In-Reply-To: <20191008093405.23533-1-olivier.matz@6wind.com> From: David Marchand Date: Thu, 17 Oct 2019 07:00:55 +0200 Message-ID: To: Olivier Matz Cc: dev , Andrew Rybchenko X-MC-Unique: O_LBfYrjP9uZUl4vrwL_Cg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] mempool: clarify default populate function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 8, 2019 at 11:35 AM Olivier Matz wrote= : > > No functional change. Clarify the populate function to make > the next commit easier to understand. After discussion offlist, changed this: Clarify the populate function to make future changes easier to understand. > > Rename the variables: > - to avoid negation in the name > - to have more understandable names > > Remove useless variable (no_pageshift is equivalent to pg_sz =3D=3D 0). > > Remove duplicate affectation of "external" variable. > > Signed-off-by: Olivier Matz > Reviewed-by: Andrew Rybchenko Applied, thanks. -- David Marchand