From: David Marchand <david.marchand@redhat.com>
To: Dekel Peled <dekelp@mellanox.com>
Cc: Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Ori Kam <orika@mellanox.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant new line char in logs
Date: Wed, 30 Oct 2019 10:52:45 +0100 [thread overview]
Message-ID: <CAJFAV8xN0HBHRyHTftRz_cELD++0xNhD-0Z7oVMkS68sDwEPZQ@mail.gmail.com> (raw)
In-Reply-To: <AM4PR05MB346014FFB22A4FB14D54012DB6600@AM4PR05MB3460.eurprd05.prod.outlook.com>
On Wed, Oct 30, 2019 at 10:40 AM Dekel Peled <dekelp@mellanox.com> wrote:
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Wednesday, October 30, 2019 11:03 AM
> > To: Dekel Peled <dekelp@mellanox.com>
> > Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> > <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>; Ori
> > Kam <orika@mellanox.com>; dev <dev@dpdk.org>
> > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant new line char
> > in logs
> >
> > On Wed, Oct 30, 2019 at 9:45 AM Dekel Peled <dekelp@mellanox.com>
> > wrote:
> > >
> > > DRV_LOG macro is used to print log messages, one per line.
> > > In several locations this macro is used with redundant '\n' character
> > > at the end of the log message, causing blank lines between log lines.
> > >
> > > This patch removes the '\n' character where it is redundant.
> >
> > Missing Fixes: ?
>
> This patch is 'cosmetic', not functional.
Having empty lines as noise when debugging is a pain for my pov.
But this is your driver, so fair enough.
--
David Marchand
next prev parent reply other threads:[~2019-10-30 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 8:42 Dekel Peled
2019-10-30 9:00 ` Slava Ovsiienko
2019-10-30 9:03 ` David Marchand
2019-10-30 9:40 ` Dekel Peled
2019-10-30 9:52 ` David Marchand [this message]
2019-11-03 13:34 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xN0HBHRyHTftRz_cELD++0xNhD-0Z7oVMkS68sDwEPZQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).