From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EBCDA00BE; Wed, 30 Oct 2019 10:53:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6A471BF97; Wed, 30 Oct 2019 10:52:59 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 227D61BF5B for ; Wed, 30 Oct 2019 10:52:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572429178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TsyBZ8YCmCWOTg81TMCoqhhyRxaBF4mGoEcvjmUdGkA=; b=cPwq5zAcktEx4ciqZbRu6/o0Qk5/vFAA46fh+Ytocdxcp+2b6k79rcY8wxqIAaBsRb7G1i kJGM/kDGSdokYgRJlANNhGaQy8EF/JQ/YAUAwJfyGBkfJehr7i36B9WCnmWbXhboKOurhm 71M5uz4XSeOxTCQAI+X35fZ17oYmrVY= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-341-1CeXQKIdP5yI4vNTopOb5g-1; Wed, 30 Oct 2019 05:52:57 -0400 Received: by mail-io1-f71.google.com with SMTP id w9so1459794iom.1 for ; Wed, 30 Oct 2019 02:52:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SHRTQtvsEhYXYmMm37E8orS44fTgsn7rWjViT5dLMVw=; b=ft0wD61eN4EHvZr/w3D8C8jBvlAdgVPSowKBI2QPg235DssE1rSI5MQUtae1cbMgKU d0WoHOtXTwV7Ktg4q3s5yKPdyEAVcfWBut46rioHgaTQtVmTnUAkqzaGAU2M/KWsMLm9 u97SNVsaoCg4+0hT1dXgXYjVGe/E03NQyzOr4f1APHeEpyjIP3C2B/K8mXinhYBFsLQj 8jIQbSguUQ6XnuUOXWwkvofgAnUuzyseFeJ8BdnNopo+Ju8obwhGKN3xhrUEdjAK5A3F p6X6fc0P7RfX3/e2Qz1A9KQs8JCB7LTYFpmhK8t+UUdEYL5WGEyLzNdkDToQJBkAUvor p5AA== X-Gm-Message-State: APjAAAXc6CSvR4/CvckR4xFWBBz8IWc7cEQudFhbrD1QcKpzcJlqp/yP XDLzfa0p4KoFMEbDw8w0zxq857dO7z9ygIB2qn5SeweWdt4MiknQciF7mxaQ95AyZNLco3IU3eS uBZtBROAGKRxItyjQU8k= X-Received: by 2002:a92:9a17:: with SMTP id t23mr32899085ili.40.1572429176618; Wed, 30 Oct 2019 02:52:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxeYTfa14CjmOIV28jR+BgUMyhcKK2wviqMDxRUhlIOWW3LrQiw2t86F61twF0/03Vs1qfMAem3iuoFoF9RmEc= X-Received: by 2002:a92:9a17:: with SMTP id t23mr32899063ili.40.1572429176306; Wed, 30 Oct 2019 02:52:56 -0700 (PDT) MIME-Version: 1.0 References: <5fa7aac59baffdc90720fc9b229f619c87a29122.1572425052.git.dekelp@mellanox.com> In-Reply-To: From: David Marchand Date: Wed, 30 Oct 2019 10:52:45 +0100 Message-ID: To: Dekel Peled Cc: Matan Azrad , Slava Ovsiienko , Shahaf Shuler , Ori Kam , dev X-MC-Unique: 1CeXQKIdP5yI4vNTopOb5g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant new line char in logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 30, 2019 at 10:40 AM Dekel Peled wrote: > > -----Original Message----- > > From: David Marchand > > Sent: Wednesday, October 30, 2019 11:03 AM > > To: Dekel Peled > > Cc: Matan Azrad ; Slava Ovsiienko > > ; Shahaf Shuler ; Ori > > Kam ; dev > > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant new line cha= r > > in logs > > > > On Wed, Oct 30, 2019 at 9:45 AM Dekel Peled > > wrote: > > > > > > DRV_LOG macro is used to print log messages, one per line. > > > In several locations this macro is used with redundant '\n' character > > > at the end of the log message, causing blank lines between log lines. > > > > > > This patch removes the '\n' character where it is redundant. > > > > Missing Fixes: ? > > This patch is 'cosmetic', not functional. Having empty lines as noise when debugging is a pain for my pov. But this is your driver, so fair enough. --=20 David Marchand