From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7C4BA0C43; Thu, 23 Sep 2021 10:21:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F30E41244; Thu, 23 Sep 2021 10:21:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D35DD41225 for ; Thu, 23 Sep 2021 10:21:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632385274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZbY26FiaqBmbCnWAtrXOdS+1LFtZYRjJlpUC4vj+6uA=; b=GodCKIaaZNBFHdGwPBk9s7bB2iyC0xuFD7Y5Bv4YD5UAh8a32ZXyFaCG1iOWmVxmrYvjBv KDhM9ZrGwRZbdNo87wyQBL6CBF7OSpvG/s6VXA1JJUXdOEw8mhgiLyHdeYIz6TeBiNmHHG CXI9wR6F5hU9dE8xE0rn283g0bpoOmU= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-Kdek2zhqP0SLXjDPWzb7wA-1; Thu, 23 Sep 2021 04:21:11 -0400 X-MC-Unique: Kdek2zhqP0SLXjDPWzb7wA-1 Received: by mail-lf1-f70.google.com with SMTP id t187-20020a19c3c4000000b003fc1361fb20so5475953lff.0 for ; Thu, 23 Sep 2021 01:21:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZbY26FiaqBmbCnWAtrXOdS+1LFtZYRjJlpUC4vj+6uA=; b=KjCOj76yqJfDWxraP0loDl6w0/vKQp8rMjXESv/Bi2WhSlpQHxOXCZBXMVn/E/ccXE NjU+uUMvt3qZXAfvtYO6ft2me/xcxiI6Sxqz65DJXVInEkPnflRA4nQYiLrSrz72D8Cp py11P2Wm6LnKYStJGQ7ozLOEZGcC9qZoaKf+r2qxTAPQ4aY25Utwv0UPD+Pxm4eUQYdE itn4QbwYOL4qk0s5BlowrymHcQ24sKsvRizpYbkAxBuoCnqo9J7VJ17yD8QCRe5DhjQR GDj20I6tCaHjheDGUd9Tsi9c256er4Hc70qeIQMywo30Dn1OKmzrRgXQQvyE7keng52r RDSg== X-Gm-Message-State: AOAM533Jm0+Roaz7PLLN14okqCztRA5kSOzDRDG5fAuTEWkGr/SeAVk9 hi2JnY5qqo1HM3q+N7fJxdZr7dZiMJjXlfP43NwuKe7sAYleDj3lZ//LMINWE3U/b3iv4j/gNrv nsWmxTMaeh20BX82O/fc= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr3093189lfe.217.1632385269927; Thu, 23 Sep 2021 01:21:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvr1N1lhNEcLFD/jZ2415Uo7W3JGVhJTjdulOPNZ17aW248dz3xpiOiWsbte/97T5go6yigX41nBpakaqP3to= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr3093169lfe.217.1632385269736; Thu, 23 Sep 2021 01:21:09 -0700 (PDT) MIME-Version: 1.0 References: <20210826145726.102081-1-hkalra@marvell.com> <20210903124102.47425-1-hkalra@marvell.com> In-Reply-To: <20210903124102.47425-1-hkalra@marvell.com> From: David Marchand Date: Thu, 23 Sep 2021 10:20:58 +0200 Message-ID: To: Harman Kalra Cc: dev , "Yigit, Ferruh" , Ajit Khaparde , Qi Zhang , Jerin Jacob Kollanukkaran , Raslan Darawsheh , Maxime Coquelin , "Xia, Chenbo" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1 0/7] make rte_intr_handle internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Harman, On Fri, Sep 3, 2021 at 2:42 PM Harman Kalra wrote: > > Moving struct rte_intr_handle as an internal structure to > avoid any ABI breakages in future. Since this structure defines > some static arrays and changing respective macros breaks the ABI. > Eg: > Currently RTE_MAX_RXTX_INTR_VEC_ID imposes a limit of maximum 512 > MSI-X interrupts that can be defined for a PCI device, while PCI > specification allows maximum 2048 MSI-X interrupts that can be used. > If some PCI device requires more than 512 vectors, either change the > RTE_MAX_RXTX_INTR_VEC_ID limit or dynamically allocate based on > PCI device MSI-X size on probe time. Either way its an ABI breakage. > > Change already included in 21.11 ABI improvement spreadsheet (item 42): > https://urldefense.proofpoint.com/v2/url?u=https-3A__docs.google.com_s > preadsheets_d_1betlC000ua5SsSiJIcC54mCCCJnW6voH5Dqv9UxeyfE_edit-23gid- > 3D0&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=5ESHPj7V-7JdkxT_Z_SU6RrS37ys4U > XudBQ_rrS5LRo&m=7dl3OmXU7QHMmWYB6V1hYJtq1cUkjfhXUwze2Si_48c&s=lh6DEGhR > Bg1shODpAy3RQk-H-0uQx5icRfUBf9dtCp4&e= > Thanks for taking care of this huge cleanup. I started looking at it. CC: Ferruh and next-net* maintainers for awareness. -- David Marchand