From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA5E5A00C5; Thu, 1 Dec 2022 11:11:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84F3A42D18; Thu, 1 Dec 2022 11:11:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 99FBC42D11 for ; Thu, 1 Dec 2022 11:11:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669889514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KcS4621MiMW/Esi6fmaLofWb2/B5Aw0Hh7xpAjGL3Yw=; b=BbL7ppDvT05iZLAASpa//xsjINhNiYL9MSFJgB6GVodWbd2bfWlnZuCKURf8Gmy+W2Plut fP+D0cPyxZYF4H5WDS1eGdpqOwut0fUL6RAzHbtHEOl7g3xXRuB5MxOEZiBGtPy3UVDeav 1xenrguxVZJgnx8+g5jTZnWTwjuuFmU= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-648-VjEWr5F_NsOWC_9gMfEUgw-1; Thu, 01 Dec 2022 05:11:53 -0500 X-MC-Unique: VjEWr5F_NsOWC_9gMfEUgw-1 Received: by mail-pj1-f70.google.com with SMTP id m2-20020a17090a730200b0021020cce6adso5513761pjk.3 for ; Thu, 01 Dec 2022 02:11:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KcS4621MiMW/Esi6fmaLofWb2/B5Aw0Hh7xpAjGL3Yw=; b=xDlwwkdpY0sF26uIdu7nZQ8BBngwESgArXrnC2eE0+ZaoLQ/BXdDEoKTEWaNSO+k7O O+Wgm6EEozKNZmGf5/5NYcza4Oh+Qx+K5lxr7K24JayWTgDOM664sc0eif8nQEt+jEAY W0Zd1Nc5s/2YfeZAA7WhgyfVf4iUyV/FfonF4g0r9riG0HCWhHPoUvVgg5NuuTrhbx1n LDx79S05ad8QImJ9QGlKwonr/Mu4Cz4jykbsfGt6C36ks1diCIfoh+pj0KxUXxGBvyi4 su2ZkmX8Hr07jefQWN3rdyTD18Ph7/Qd6b9UwNeRvJkcCkdUljnBez+XCXNMDmzWeib4 7OTw== X-Gm-Message-State: ANoB5pmhxV0ikjNdcmUoxOd3wZr4qBvHKGBgcChTmHXmcFC88mGER5Vf lhSU7pOkLulVik9D3JbnO3as9ponuTUAf1+6mOr/XU6NPOja4yqwBmDI/WsiWHzRWzb9gUi6RSo Wdp4kg1ijSYOMF4iCNmA= X-Received: by 2002:a17:90a:f48d:b0:212:c877:e948 with SMTP id bx13-20020a17090af48d00b00212c877e948mr76937926pjb.39.1669889512046; Thu, 01 Dec 2022 02:11:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf5jYFsMzx9iy9Ac6WmnOHmxxiaP25bzyZpWzAl3+l2o29NMo2D9Vgan4urvexEGcC8hTy+pcOCaKI2VAs1iMR4= X-Received: by 2002:a17:90a:f48d:b0:212:c877:e948 with SMTP id bx13-20020a17090af48d00b00212c877e948mr76937906pjb.39.1669889511748; Thu, 01 Dec 2022 02:11:51 -0800 (PST) MIME-Version: 1.0 References: <20221129140032.35940-1-david.marchand@redhat.com> <20221130100204.214181-1-david.marchand@redhat.com> <191d5966-dd66-3a26-2789-6c6e5ce78aa2@amd.com> In-Reply-To: From: David Marchand Date: Thu, 1 Dec 2022 11:11:39 +0100 Message-ID: Subject: Re: [PATCH v2] drivers: fix symbol exports when map is omitted To: Bruce Richardson Cc: Ferruh Yigit , Luca Boccassi , dev@dpdk.org, stable@dpdk.org, Thomas Monjalon , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 30, 2022 at 4:42 PM Bruce Richardson wrote: > > On Wed, Nov 30, 2022 at 04:02:26PM +0100, David Marchand wrote: > > On Wed, Nov 30, 2022 at 11:44 AM Ferruh Yigit wrote: > > > > > > On 11/30/2022 10:02 AM, David Marchand wrote: > > > > ld exports any global symbol by default if no version script is passed. > > > > As a consequence, the incriminated change let any public symbol leak > > > > out of the driver shared libraries. > > > > > > > > Hide again those symbols by providing a default map file which > > > > unexports any global symbol using a local: * catch-all statement. > > > > > > > > The checks are skipped for this default map file as it is intentionnally > > > > an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol > > > > maps")) and there is nothing else to check in this map. > > > > > > > > While at it, move Windows specific objects where needed for better > > > > readability. > > > > > > > > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") > > > > Cc: stable@dpdk.org > > > > > > > > Reported-by: Luca Boccassi > > > > Signed-off-by: David Marchand > > > > Tested-by: Ferruh Yigit > > > > > > Tested v2, looks good. > > > 'check-symbol-maps.sh' warning fixed too. > > > > Thanks Ferruh. > > > > Bruce / Luca, could you review / confirm it is ok for you? > > > LGTM, thanks. Thanks Bruce. I prefer to separate the "cosmetic" part around Windows (and fix lib/meson.build too), so I sent a v3 series with only the first patch marked as backport. -- David Marchand