Re: [PATCH] net/virtio-user: fix number of vrings calculation

[David Marchand <david.marchand@redhat.com>]

On Fri, Feb 10, 2023 at 4:10 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> When moving to dynamic allocation of vrings metadata, the
> number of vrings to allocate was incremented if the backend
> supports control queue.
>
> The problem is that the control queue metadata have to be
> allocated even if the backend does not use it directly,
> since the control queue is managed by the Virtio-user layer
> as soon as multiqueue is negotiated..
>
> This patch fixes this by incrementing the number of vrings
> as soon as the device features have VIRTIO_NET_F_MQ.
>
> Fixes: d57c3a601e44 ("net/virtio-user: remove max queues limitation")
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Acked-by: David Marchand <david.marchand@redhat.com>

> ---
>
> I plan to squash it with faulty commit in the Virtio branch
> since it has not been pulled yet by Thomas once acked and
> if no objection.

No objection from me.


-- 
David Marchand