From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C794141C61; Fri, 10 Feb 2023 16:24:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54272410D3; Fri, 10 Feb 2023 16:24:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 40F22410D0 for ; Fri, 10 Feb 2023 16:24:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676042651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bDKILkUh31EZwU3HKocl2CyydCYhvNzJQMpEnmEwSkI=; b=hWSZ0l4ELSy507Kf1IbbSt2d1isejURbQKsKhHT/33x0j8nLy+wNDFBXazyhtNXN1pJ3h1 S7VeP9xXfrUuGOb4V/R6sfmmIzMo1ZCBujvPXueEl4Fiv7ZLS8Fv8uOBAKq7twz69tIggq kLZRN8up5MugvHQesiVcwygGMcPR4w0= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-193-HL_n3H0-O7yeEDMkexrj8Q-1; Fri, 10 Feb 2023 10:24:10 -0500 X-MC-Unique: HL_n3H0-O7yeEDMkexrj8Q-1 Received: by mail-pg1-f199.google.com with SMTP id x3-20020a654143000000b004f2f2dafb21so2691749pgp.0 for ; Fri, 10 Feb 2023 07:24:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bDKILkUh31EZwU3HKocl2CyydCYhvNzJQMpEnmEwSkI=; b=aRVIm7jAdjSsWzYbs49pdpSB1UM9+U2fu9lvMV2NETqC94z+2+6K5/wbLte/z/ZhHY fOKQMT+rBuQVme71QcJaEya/KwWzFXE1gGnxSCEi8e9KaeS88oMlDkBIf+B5yiIxY1Ih Ru24l8oi5lq+jdFuUhw86y6IjwkVWKdKSuG1I1oiIZaGoLNn5sEUqmIgLFSQn+GmAjV1 Wi4qBOpXkH+k7V6EkAIWgauH7xXfm1PvWcVn8tCHBnWWq9hyMrkI1X+WdvWkDqBdiQ+4 dnZBQul3OgLch1WTSqzd6IreygpRbuo98lY4qiH5DnayI5TIhlNq0B0Nqdvq3s0py3Jp sUZQ== X-Gm-Message-State: AO0yUKXASmlqvz4OB73iGgPcziFWTQPhp8fyMO8LGSaF97pGeUlkNjR1 Kv0nnl9I6LreZFXBL+Yb7ZbexiivVboNtaTH2BMQRs/KYQUEH6Z8QpXrEcgH+p3AlQOqzaX7Jht nI/wxJh3fytnF3QKj2k8= X-Received: by 2002:a63:9512:0:b0:478:b1f3:d874 with SMTP id p18-20020a639512000000b00478b1f3d874mr2736950pgd.26.1676042649503; Fri, 10 Feb 2023 07:24:09 -0800 (PST) X-Google-Smtp-Source: AK7set9kvb9nzgy0IkJQXw/TDZJ5rEKyaqM0ZbRH9UO7/6k04XRaUxVyiDGIEdhS6A6NHyzLymm7qrRaVcd64nw9i0c= X-Received: by 2002:a63:9512:0:b0:478:b1f3:d874 with SMTP id p18-20020a639512000000b00478b1f3d874mr2736945pgd.26.1676042649237; Fri, 10 Feb 2023 07:24:09 -0800 (PST) MIME-Version: 1.0 References: <20230210151044.229324-1-maxime.coquelin@redhat.com> In-Reply-To: <20230210151044.229324-1-maxime.coquelin@redhat.com> From: David Marchand Date: Fri, 10 Feb 2023 16:23:57 +0100 Message-ID: Subject: Re: [PATCH] net/virtio-user: fix number of vrings calculation To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com, eperezma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 10, 2023 at 4:10 PM Maxime Coquelin wrote: > > When moving to dynamic allocation of vrings metadata, the > number of vrings to allocate was incremented if the backend > supports control queue. > > The problem is that the control queue metadata have to be > allocated even if the backend does not use it directly, > since the control queue is managed by the Virtio-user layer > as soon as multiqueue is negotiated.. > > This patch fixes this by incrementing the number of vrings > as soon as the device features have VIRTIO_NET_F_MQ. > > Fixes: d57c3a601e44 ("net/virtio-user: remove max queues limitation") > > Signed-off-by: Maxime Coquelin Acked-by: David Marchand > --- > > I plan to squash it with faulty commit in the Virtio branch > since it has not been pulled yet by Thomas once acked and > if no objection. No objection from me. -- David Marchand