From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10DD7A04BB; Tue, 6 Oct 2020 17:06:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4C1C1B669; Tue, 6 Oct 2020 17:06:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id C5BBB1B62E for ; Tue, 6 Oct 2020 17:06:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601996763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JifLJRlxpt6SYxnvtQcac8ri+VEZkLpEYBV+8JcRvPg=; b=Ze4S/UW7k22Y0+x3BV9NnrBwLMwPfwyWKNGZu/6hJIEwxM2vl5s4W17JEmUAoJjMuH5EDx 4puvh0T5lGGP2nIbCskpBAsj8VANrtKJpesrz6kgtZL5Jk16pVvdN6B32HqxUcpqz6z9fU C9KoWVPuBrLNsZQXmDIQlmXmT03QrjE= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-539-7MPmEDIBPWGj4iSsk8yHLg-1; Tue, 06 Oct 2020 11:05:59 -0400 X-MC-Unique: 7MPmEDIBPWGj4iSsk8yHLg-1 Received: by mail-vs1-f72.google.com with SMTP id v203so893402vsv.8 for ; Tue, 06 Oct 2020 08:05:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JifLJRlxpt6SYxnvtQcac8ri+VEZkLpEYBV+8JcRvPg=; b=LxNw2TiZsZfURfM4rvvSdAR1Mj2MOHYVHQKhHTPzQhj8qww1LcgaBpOMK9rEbvCeEa 2runZBrV4iuyZ7ruYhFY4Z64dQBM1Qa7cUJiEdGbUWv2l5RBydnAyOtHs72y47BJ45yi P8+3EcTfuNVOlTdbdxYgkGjus+MsPdscVU3Ylg4tB5JMC4P6SZwB63qmdTC3Q4jA8e41 hYNkX/v0nNchOU6rWvulcmycauzUnTa+RoNKq6VTAsdYBNYT4gAnaL3Ok+RVs6oYNjz/ R3TVT848y3rchUdGYtbHfivykexZ99q/WhZ5nfVyr1FJTjI9HnEwYL136HchoO1OsWis 8K5g== X-Gm-Message-State: AOAM532V9uH45Uv7KnUo9Pvo8G7/YbgThWroNFlYV8GuIeHH9UIa23P1 xl8b3kHJzHQRPjY/MhAK8LNV/UlNmYmoS6S3qkhN9rnpqON25gcQcwBvVJPdVy7V/XK/wTAjA3f f8YCZkElhvz0rPkuxWac= X-Received: by 2002:a67:fd7a:: with SMTP id h26mr3501625vsa.27.1601996759168; Tue, 06 Oct 2020 08:05:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/KUMuhKK48uQtBVt1bttthibn3KCX9qaZkYF1GAEbTf8riryE6zAim5QxJ6JklXChsJEgFJmBGFCOKmxvgek= X-Received: by 2002:a67:fd7a:: with SMTP id h26mr3501595vsa.27.1601996758926; Tue, 06 Oct 2020 08:05:58 -0700 (PDT) MIME-Version: 1.0 References: <20200915165025.543-1-konstantin.ananyev@intel.com> <20201005184526.7465-1-konstantin.ananyev@intel.com> In-Reply-To: <20201005184526.7465-1-konstantin.ananyev@intel.com> From: David Marchand Date: Tue, 6 Oct 2020 17:05:48 +0200 Message-ID: To: Konstantin Ananyev Cc: dev , Jerin Jacob Kollanukkaran , "Ruifeng Wang (Arm Technology China)" , Vladimir Medvedkin , Thomas Monjalon , Ray Kinsella , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 00/14] acl: introduce AVX512 classify methods X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 5, 2020 at 9:44 PM Konstantin Ananyev wrote: > > These patch series introduce support of AVX512 specific classify > implementation for ACL library. > It adds two new algorithms: > - RTE_ACL_CLASSIFY_AVX512X16 - can process up to 16 flows in parallel. > It uses 256-bit width instructions/registers only > (to avoid frequency level change). > On my SKX box test-acl shows ~15-30% improvement > (depending on rule-set and input burst size) > when switching from AVX2 to AVX512X16 classify algorithms. > - RTE_ACL_CLASSIFY_AVX512X32 - can process up to 32 flows in parallel. > It uses 512-bit width instructions/registers and provides higher > performance then AVX512X16, but can cause frequency level change. > On my SKX box test-acl shows ~50-70% improvement > (depending on rule-set and input burst size) > when switching from AVX2 to AVX512X32 classify algorithms. > ICX and CLX testing showed similar level of speedup. > > Current AVX512 classify implementation is only supported on x86_64. > Note that this series introduce a formal ABI incompatibility The only API change I can see is in rte_acl_classify_alg() new error code but I don't think we need an announcement for this. As for ABI, we are breaking it in this release, so I see no pb. > with previous versions of ACL library. > > v2 -> v3: > Fix checkpatch warnings > Split AVX512 algorithm into two and deduplicate common code Patch 7 still references a RTE_MACHINE_CPUFLAG flag. Can you rework now that those flags have been dropped? Thanks. -- David Marchand