From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B92541E9D; Wed, 15 Mar 2023 10:49:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7761A40A7A; Wed, 15 Mar 2023 10:49:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D9E6E40141 for ; Wed, 15 Mar 2023 10:48:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678873738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ewHymnnURodIbue+PYVVxKWoRG3BsezEYo+n3WkLta8=; b=X1kbSbEF0q/QC1OLbgVXWynWox84BSDioIO3PP2EaYv487gOixx1vyn9RTNfRuTDR8bqOo zQIdd2kq2WSYvWrklQYvsh6G3le0pE+g540j8bMMmTZfSL/Zk5gXK2MYE4dcY97xiwaCV5 BH3bAsIyoOyo0Wo9+kl828cVU39sc/8= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-tNLZ_7tuOOyXaU2W_nDnyQ-1; Wed, 15 Mar 2023 05:48:57 -0400 X-MC-Unique: tNLZ_7tuOOyXaU2W_nDnyQ-1 Received: by mail-pf1-f197.google.com with SMTP id s20-20020a056a00179400b005c4d1dedc1fso9903066pfg.11 for ; Wed, 15 Mar 2023 02:48:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678873736; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ewHymnnURodIbue+PYVVxKWoRG3BsezEYo+n3WkLta8=; b=fG0BsoB3l0IKjLrFS/LH2+YkuGcE/1nsJe64kSP7nyuNJdvkbZKNNK4AjYxojZc9bE GmErwkHUv/DHKx2auans0ERRvFLA0dbQ9s9EqPaSfkUs1+CD4RcUACUiMFpnna2ENppG oN1FKk3CHGJY0KjwUN611GCXXb4Ui6QdopMpatkqfCWUWF5DOtJZg9U263dW+3sIwdg+ Kl7NFc2X+tVjXj2NVylDgj+ElCzYRHQRQf6RBspalGd6wI5U6EXjPg01oxW+H0gYkNxI XHG7zQmSdsgKPbWZgkfbPFOKZEfGlIzQ8ikfTAZTeWmQjrh47gLagC4s67gqy0hYH0aK O7Fw== X-Gm-Message-State: AO0yUKWEcFeryRL0xowW0d2HDtoUQiOXYDhH49OAQGDjVaEYYbQT/cJb FM48kE5ul4hGcHBkMH6WEHkmBvAI3dyDtU7qg+/vtjkcx7jLjc2wbo8OLSuIhr6SPw8nSOi1Os+ 6opi7eQvQd31tfY02uh8= X-Received: by 2002:a65:66cb:0:b0:50b:dda2:6140 with SMTP id c11-20020a6566cb000000b0050bdda26140mr393006pgw.11.1678873736010; Wed, 15 Mar 2023 02:48:56 -0700 (PDT) X-Google-Smtp-Source: AK7set/WsYPCKL7jimXAvOCoN7mw4qnW6VkrQM9T368iOWDDlWWHtVyXAExfUq9/yomgVli7o6wbgTe7te8UGxMFXxA= X-Received: by 2002:a65:66cb:0:b0:50b:dda2:6140 with SMTP id c11-20020a6566cb000000b0050bdda26140mr392997pgw.11.1678873735721; Wed, 15 Mar 2023 02:48:55 -0700 (PDT) MIME-Version: 1.0 References: <20230311145606.5523-1-syalavarthi@marvell.com> In-Reply-To: From: David Marchand Date: Wed, 15 Mar 2023 10:48:44 +0100 Message-ID: Subject: Re: [PATCH] mldev: fix identical code in conditional branches To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 13, 2023 at 12:01=E2=80=AFPM David Marchand wrote: > On Sat, Mar 11, 2023 at 3:56=E2=80=AFPM Srikanth Yalavarthi > wrote: > > > > Fix identical code in different conditional branches in float32 > > to float16 conversion function. Issue reported in coverity scan. > > > > Coverity issue: 383651 > > Fixes: 9637de38a2e3 ("mldev: add scalar type conversion") > > > > Signed-off-by: Srikanth Yalavarthi > Reviewed-by: David Marchand Applied, thanks. --=20 David Marchand