From: David Marchand <david.marchand@redhat.com>
To: Huichao Cai <chcchc88@163.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit
Date: Tue, 9 Nov 2021 09:14:25 +0100 [thread overview]
Message-ID: <CAJFAV8xOp6iSxB1jLGo4UHRcVOyC14JSpQiCX+ypDWBDDOgSMg@mail.gmail.com> (raw)
In-Reply-To: <79a325b9.dfd.17d0280731a.Coremail.chcchc88@163.com>
Hello,
On Tue, Nov 9, 2021 at 3:22 AM Huichao Cai <chcchc88@163.com> wrote:
> >6-0: checking 6688 with 3360
>
> This test case failed because there was a bug in the "rte_ipv4_fragmentation.c" file.
> It is this test case that discovers this bug. A patch to fix the bug has been received.
Why was it separate from the fix?
I could not tell from this current patch that there was a dependency.
It could (should?) have been a single patch.
> The fix bug patche is:
> ip_frag: fix the buf of fragmenting IPv4 fragment - Patchwork (dpdk.org)
A link to patchwork would avoid me wasting time looking for it.
I guess this is the patch Thomas merged last night.
On the patch itself, the title is vague.
It should summarize what the change adds to the unit tests.
test/ipfrag: check fragment offsets
Thanks.
--
David Marchand
next prev parent reply other threads:[~2021-11-09 8:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 7:58 huichao cai
2021-10-28 12:24 ` Ananyev, Konstantin
2021-11-10 10:46 ` David Marchand
2021-11-08 20:28 ` David Marchand
2021-11-09 2:21 ` Huichao Cai
2021-11-09 8:14 ` David Marchand [this message]
2021-11-09 9:03 ` Huichao Cai
2021-11-09 9:16 ` David Marchand
2021-11-09 9:29 ` Huichao Cai
2021-11-09 9:14 ` Huichao Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xOp6iSxB1jLGo4UHRcVOyC14JSpQiCX+ypDWBDDOgSMg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chcchc88@163.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).