From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE7EF436DC; Wed, 13 Dec 2023 08:57:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8343B42E88; Wed, 13 Dec 2023 08:57:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E658742E55 for ; Wed, 13 Dec 2023 08:57:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702454240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NWx9LzPfD0oX4NUk2Dia8MAGPcO4rE16WvbKBzUnIuw=; b=gbQY7Nd1ME3Om8ilfoDxQH2/o8ffUCr9eh/2nuuPe6t/1JI0yem0NB9eS97vT62lN9vt86 v84JPF56vX+4KKmtiq5S2A69QMJIr7xofVC8Di5bF7G2jfzm7uKhwsc1tUMyBfQmisI3VD maylzq6U2eGeDUcRp5EUTm/oin4+h08= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-Ow-baG8_N6GfFWouXQXxrA-1; Wed, 13 Dec 2023 02:57:18 -0500 X-MC-Unique: Ow-baG8_N6GfFWouXQXxrA-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ca005e8de4so55092951fa.3 for ; Tue, 12 Dec 2023 23:57:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702454237; x=1703059037; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NWx9LzPfD0oX4NUk2Dia8MAGPcO4rE16WvbKBzUnIuw=; b=LaV3dmAWYpzAihOmO4dI2pT/4IXYR1PDdJjaAm+gKwo5zVZFxKUY6BoVfR0Nj5GzGw 2nELeYXD7UOhkWTEYpzgq5U5+27leUHFE8m/AmPGMsoxAR5Nnb2kElNakQUv93d0hXIp +KRHyVBNoBqPcLnOu43k9+0FGM62y3zJbNuiqI0KC8zMWufsAx0KGtRzhc9uijOLAPof /DmmSBNXvLbuzZpLdHrP0lK2L+29WJQmZbv7MAnTESZw9ymJGBmTMESUUOVe4glsZNum VLTn9KCCScjh/A+tXipjPvaygibYs9mybDEn+xkvU3K2hXHJuDhJDaF2J/ngIQ228F6R AJCg== X-Gm-Message-State: AOJu0YwjqDsRGUp4viA+U/wUkV9htg0EFvESynDaBGYhJSgPcpdTmdET ZTFaO0U5fn5W9Y9cU1D8igj8MxbQ/NFyoRq8v+Z85s4NH/QJ8QXUcvioMC4z6FxsgnA9SqUYSGG nKh9hTZBqKRTNGEg9oYU= X-Received: by 2002:a2e:9403:0:b0:2cb:2576:85f6 with SMTP id i3-20020a2e9403000000b002cb257685f6mr3131004ljh.86.1702454237481; Tue, 12 Dec 2023 23:57:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfyLc0JT0Xm7v0wAhQd7N7CGb+OrwOL/ZRcUOGHRDDKqp6ywwoTxQRmUDxr9JlFHrOWtch4IctAJ8y/Q3Myiw= X-Received: by 2002:a2e:9403:0:b0:2cb:2576:85f6 with SMTP id i3-20020a2e9403000000b002cb257685f6mr3130996ljh.86.1702454237162; Tue, 12 Dec 2023 23:57:17 -0800 (PST) MIME-Version: 1.0 References: <20231210012455.20229-1-ajit.khaparde@broadcom.com> In-Reply-To: From: David Marchand Date: Wed, 13 Dec 2023 08:57:05 +0100 Message-ID: Subject: Re: [PATCH v2 00/14] support new 5760X P7 devices To: Ajit Khaparde Cc: dev@dpdk.org, Ferruh Yigit , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 13, 2023 at 6:34=E2=80=AFAM Ajit Khaparde wrote: > > On Sat, Dec 9, 2023 at 5:31=E2=80=AFPM Ajit Khaparde wrote: > > > > While some of the patches refactor and improve existing code, > > this series adds support for the new 5760X P7 device family. > > Follow-on patches will incrementally add more functionality. > > > > v1->v2: > > - Fixed unused variable error > > - Fixed some spellings > > - Code refactoring and fixes in backing store v2 > > Patchset applied to dpdk-next-net-brcm for-next-net branch. > Thanks In case you did not read my mail about mirroring in github, this for-next-net branch has been mirrored (cool). And now GHA runs on this branch, but it failed (not cool). https://github.com/DPDK/dpdk/actions/runs/7191182897/job/19585464602 Looking at the error, I think you applied the v2 (series 30499) and not the v3 (series 30511) of this work. $ git diff ovsrobot/series_30499..ovsrobot/series_30511 diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.= c index 8aca3c6fba..75e968394f 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1312,7 +1312,7 @@ bnxt_receive_function(struct rte_eth_dev *eth_dev) } static eth_tx_burst_t -bnxt_transmit_function(struct rte_eth_dev *eth_dev) +bnxt_transmit_function(__rte_unused struct rte_eth_dev *eth_dev) { #if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) uint64_t offloads =3D eth_dev->data->dev_conf.txmode.offloads; @@ -2929,7 +2929,7 @@ bnxt_dev_set_mc_addr_list_op(struct rte_eth_dev *eth_= dev, bp->nb_mc_addr =3D nb_mc_addr; if (nb_mc_addr > BNXT_MAX_MC_ADDRS) { - PMD_DRV_LOG(INFO, "Number of Mcast MACs added (%d) exceeded Max supported (%d)\n", + PMD_DRV_LOG(INFO, "Number of Mcast MACs added (%u) exceeded Max supported (%u)\n", nb_mc_addr, BNXT_MAX_MC_ADDRS); PMD_DRV_LOG(INFO, "Turning on Mcast promiscuous mode\n"); vnic->flags |=3D BNXT_VNIC_INFO_ALLMULTI; diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index c6d774bd14..e56f7693af 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -5653,8 +5653,6 @@ int bnxt_hwrm_func_backing_store_types_count(struct bnxt *bp) req.type =3D rte_cpu_to_le_16(type); rc =3D bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB); HWRM_CHECK_RESULT(); - if (rc !=3D 0) - return rc; flags =3D rte_le_to_cpu_32(resp->flags); type =3D rte_le_to_cpu_16(resp->next_valid_type); --=20 David Marchand