From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 101F445B68; Fri, 18 Oct 2024 09:00:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37A5A402EB; Fri, 18 Oct 2024 09:00:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6C3CF40265 for ; Fri, 18 Oct 2024 09:00:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729234824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UrAs+WXBmMcf8UcpXwNoDSxpkRBdi1sOVJgRnNulzso=; b=idA1ZqnLly42Yz8WEayPXy+4EwVEOA9VGwyQx1wm85TSGkUHXVPlJMsVNvKUsT53Os2MG8 vkOfp7AnTCPQPk0CLEsgGxRd7a+IKNGIayWzwoiLUsTLmJiVfc3m0YQ8Lfkr3QbaJpW5B9 YiPQbKUyruFNlbt+/pBgJZrf6D6oopM= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-RNfEpHcENpiZu3Wq-9xtCQ-1; Fri, 18 Oct 2024 03:00:23 -0400 X-MC-Unique: RNfEpHcENpiZu3Wq-9xtCQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2faca747f94so10082101fa.3 for ; Fri, 18 Oct 2024 00:00:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729234822; x=1729839622; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UrAs+WXBmMcf8UcpXwNoDSxpkRBdi1sOVJgRnNulzso=; b=pSwux4VL0KWUhbBz/nAOE0avn+qs+I6f6+8QMhGE/KdS8PMH6LYuyKSJ4f8X+yAe7b OWblxCe0JaVpEMEK38YEpT8H85YCS5/4zDmuw1/uK8y+iY7augMTFrx7F5bZYUEK5HoC jlIgO4Z/9eKreOHPc1whi4r3n1OBeGsel9h0tjBB0HQf4ioSRlG5mfSaick0bF6APbJD psAq4Hht6b0fC+iVFy2ji4ZJnAVzcH+8tP9tsT/YRIHEQk/XFdNCyYfW4/JpYuBadIYL FBYZQdrO9KEMqAuXcAfDZBWiPPd52UBFAeTDA0OaelnPlAPGHuHovzQ3bJ3Rasaz3Jkm 3j1g== X-Forwarded-Encrypted: i=1; AJvYcCVOHkgSSn2mR07Q1G+5AmHEP9IavJ5FaroKN513OZ0uGPOw2Gq0MvNWpDcLgOcd+6BWZcY=@dpdk.org X-Gm-Message-State: AOJu0YwsvjJmcsYKIJjmGnaZnsKw5EOcvT9YaWZaJ9KPSc46wAUaDQEj fkq3vVW9u8szBt1267r7UoHqMCgHVi5y/zAroZML0aK6WtoCi1jpsOZV/pWQOg5ff1mOzMHMoZG NSljiFzfTGVRskfX5F+3pLB41du+LIOrcTCNSIlGcb0CV8xPBZwK8j50uVWgzCDRvkXyL49VnYx zenCX5QBcoBMLPEvc= X-Received: by 2002:a05:6512:ea8:b0:539:f2f6:c70f with SMTP id 2adb3069b0e04-53a1520b410mr677228e87.8.1729234821969; Fri, 18 Oct 2024 00:00:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFem92D93aFZm6/GI1S1uNkTyat9s88kSA2kKHUBmwUUmT7RSXkLdwwaAH29jve47BfwYw/spFQdpl4AyIZKX4= X-Received: by 2002:a05:6512:ea8:b0:539:f2f6:c70f with SMTP id 2adb3069b0e04-53a1520b410mr677206e87.8.1729234821560; Fri, 18 Oct 2024 00:00:21 -0700 (PDT) MIME-Version: 1.0 References: <20241017234233.3456943-1-joshwash@google.com> In-Reply-To: <20241017234233.3456943-1-joshwash@google.com> From: David Marchand Date: Fri, 18 Oct 2024 09:00:10 +0200 Message-ID: Subject: Re: [PATCH] net/gve: replace typedefs with macros in gve osdep To: Joshua Washington Cc: Jeroen de Borst , Rushil Gupta , Junfeng Guo , Xiaoyun Li , Haiyue Wang , dev@dpdk.org, stable@dpdk.org, Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Joshua, On Fri, Oct 18, 2024 at 1:42=E2=80=AFAM Joshua Washington wrote: > > Currently, a number of integer types are typedef'd to their > corresponding upserspace or RTE values. This can be problematic if these > types are already defined somewhere else, as it would cause type > collisions. This patch changes the typedefs to #define macros which are > only defined if the types are not defined already. > > Fixes: c9ba2caf6302 ("net/gve/base: add OS-specific implementation") > Fixes: abf1242fbb84 ("net/gve: add struct members and typedefs for DQO") > Cc: stable@dpdk.org > > Signed-off-by: Joshua Washington > Suggested-by: David Marchand Re-reading /usr/include/linux/types.h, I suspect the #ifndef on each type is unneeded (since always true: those types are not #define'd in the first place). But in any case, this looks ok to me. Thanks for the fix, applied in main. --=20 David Marchand