Re: [dpdk-dev] [PATCH] eal: allow hugetlbfs sub-directories

[David Marchand <david.marchand@redhat.com>]

On Tue, Aug 17, 2021 at 10:05 PM John Levon <john.levon@nutanix.com> wrote:
> On Mon, Aug 09, 2021 at 12:24:34PM +0100, John Levon wrote:
>
> > get_hugepage_dir() was implemented in such a way that a --huge-dir
> > option had to exactly match the mountpoint, but there's no reason for
> > this restriction: DPDK might not be the only user of hugepages, and
> > shouldn't assume it owns an entire mountpoint. For example, if I have
> > /dev/hugepages/myapp, and /dev/hugepages/dpdk, I should be able to
> > specify:
> >
> > --huge-dir=/dev/hugepages/dpdk/
> >
> > and have DPDK only use that sub-directory.
> >
> > Fix the implementation to allow a sub-directory within a suitable
> > hugetlbfs mountpoint to be specified, preferring the closest match.
> >
> > Signed-off-by: John Levon <john.levon@nutanix.com>
> > ---
> > v2: prefer closer matches
> > v3: checkpatch fixes
> > v4: fix docs, added tests
>
> Anyone like to (re) review?

Your patch lgtm, I tested a few scenarios I had in mind and it looks ok.
Dmitry offered to rebase after your patch, can you send a new revision
with following updates?
- This patch only concerns Linux, so the title prefix should be eal/linux,
- Jerin asked for a release notes update, a quick description is fine,
- Dmitry mentionned he acked your v3, so you can add it.


Thanks.

-- 
David Marchand