From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B8B4A04AB; Wed, 6 Nov 2019 14:49:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFC601C1B5; Wed, 6 Nov 2019 14:49:15 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 6E4331C1B4 for ; Wed, 6 Nov 2019 14:49:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573048153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q2cDV4ws4vZ+Tz20Vwr0Z4UBvGP23cArApjEcUEwyrI=; b=XPOewga8rawjU7QRjzaciOp0m6IJsmzZeNix5oCPERIL6Pm83puBHMziEINsirkdi3dYlp RZfTaXecndWpvLpv9WFuGxLx56CWj915+Af32++iFKrHtkYaS8YCwRPR0IKJxz7RNosYk8 IQvokYEZhUNclq4Yw/iD4TyjBTOmggo= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-LuqSbN0uMbizirHdc_duIg-1; Wed, 06 Nov 2019 08:49:10 -0500 Received: by mail-vs1-f71.google.com with SMTP id e127so1924009vsc.16 for ; Wed, 06 Nov 2019 05:49:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3YnDWJQa9qd68GCbUg9V9z7Vve6VeFYLQ2g+0k5aYFM=; b=GDARor6PyC3hqRsC6aOqzXxxYbQwg/EpGCmUwP6xXVxz3DpXJ/KwRmbPNSJ3qG4rVE QCPmqvNvaXbELqzX6Vgm1ODyACAyWwlo1yQTRYZRwGPO/Lsdo3jcvrUnTelbf/gDM5n5 joFKckR727hMe8fBqu1hVI+DAv15KG96KPXxDPVQhfeTi8TsFVSp6b/ZUBE+7aRIBh8p SJrUiTfSL/HTo3KiW2F6H+KbpF9kbof55gOOCiqbHNPtrUaRnuGMfMRXqrWkWzmkkFP6 C8ayWJppMLcK86I6vFHln4v3FNNyAgcPrtDxm4m+BQbcuo1KnvgL/G6JUGHDGVejkESv N2AQ== X-Gm-Message-State: APjAAAWCUDknRACzK6cVZFTqb1S4juacv12c7iXOwDxCQaK+CUN58lnC u8F7QIB+rJFDz5hstZ+6uTYPsT3PechpvH44h4X5PZke6KL9DM/RKlI2AVH0+2obrFP1efbMSdd lk3v43AEHcyRXMNb7f1o= X-Received: by 2002:a67:7d95:: with SMTP id y143mr1309370vsc.39.1573048149820; Wed, 06 Nov 2019 05:49:09 -0800 (PST) X-Google-Smtp-Source: APXvYqxF7LOQ/PqSmU8P1NMapcm6KQbicQWdNsIbSE8FrfaTy8ZWJnNfWKC6h2kXZL7m5kkSU8nwk7C2poUBxFj5eTA= X-Received: by 2002:a67:7d95:: with SMTP id y143mr1309347vsc.39.1573048149485; Wed, 06 Nov 2019 05:49:09 -0800 (PST) MIME-Version: 1.0 References: <2302363.xZHtmyloc2@xps> <5980E9BB-2D78-43C5-890A-05B6BAC30071@cisco.com> <911c9f45-ef00-0a9c-1e03-473ccbc89b9c@intel.com> In-Reply-To: <911c9f45-ef00-0a9c-1e03-473ccbc89b9c@intel.com> From: David Marchand Date: Wed, 6 Nov 2019 14:48:57 +0100 Message-ID: To: "Burakov, Anatoly" , "Damjan Marion (damarion)" Cc: Thomas Monjalon , Shahaf Shuler , Ray Kinsella , dev , Neil Horman , John McNamara , Marko Kovacevic , Bruce Richardson X-MC-Unique: LuqSbN0uMbizirHdc_duIg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 25, 2019 at 2:23 PM Burakov, Anatoly wrote: > > On 25-Oct-19 12:13 PM, Damjan Marion (damarion) wrote: > > > > > >> On 25 Oct 2019, at 00:32, Thomas Monjalon wrote: > >> > >> 24/10/2019 21:09, David Marchand: > >>> On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov > >>> wrote: > >>>> > >>>> The rte_vfio_dma_map/unmap API's have been marked as deprecated in > >>>> release 19.05. Remove them. > >>>> > >>>> Signed-off-by: Anatoly Burakov > >>>> --- > >>>> > >>>> Notes: > >>>> Although `rte_vfio_dma_map` et al. was marked as deprecated in o= ur documentation, > >>>> it wasn't marked as __rte_deprecated in code. Should we still re= move it? > >>> > >>> I can see that vpp is still using this api. > >>> I would prefer we get some ack from their side. > >>> > >>> Shahaf? > >>> Ray? > >>> > >>> Do you guys have contact with VPP devs? > >> > >> +Cc Damjan > > > > Thanks for looping me in. If I remember correctly that was used only to= get mlx PMDs working. > > We can remove that calls but then mlx PMDs will stop working unless the= re is alternative solution. > > > > From my perspective it is not big issue as we already have native rdma= based mlx support, but i would expect that other people will complain. > > > > Is there alternative way to tell DPDK about DMA mapping? > > The rte_vfio_container_dma_map(VFIO_DEFAULT_CONTAINER, ...) is the exact > equivalent of the functions being removed. Also, rte_dev_dma_map() is > supposed to be the more general DMA mapping API that works with VFIO and > with any other bus/device-specific DMA mapping. > > So yes, a simple search and replace for "rte_vfio_dma_(un)?map(" to > "rte_vfio_container_dma_(un)?map(VFIO_DEFAULT_CONTAINER, " should > trigger exactly the same behavior. The issue on VFIO_DEFAULT_CONTAINER seems fixed. The deprecation had been announced (even if it was for 20.02) and we have a replacement. So I am for taking this patch. Any objection? --=20 David Marchand