* [PATCH] dumpcap: remove bogus rte_free()
@ 2022-10-20 22:18 Stephen Hemminger
2022-10-21 13:06 ` David Marchand
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2022-10-20 22:18 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
At end of program there is call to rte_free() which is passing
a bogus value. There is no "bpf_filter" defined in this application;
it ends up being a text address inside pcap library.
Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/dumpcap/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index e0a3477d912f..e49558c2534a 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -849,7 +849,7 @@ int main(int argc, char **argv)
pcap_dump_close(out.dumper);
cleanup_pdump_resources();
- rte_free(bpf_filter);
+
rte_ring_free(r);
rte_mempool_free(mp);
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] dumpcap: remove bogus rte_free()
2022-10-20 22:18 [PATCH] dumpcap: remove bogus rte_free() Stephen Hemminger
@ 2022-10-21 13:06 ` David Marchand
0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2022-10-21 13:06 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
On Fri, Oct 21, 2022 at 12:19 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> At end of program there is call to rte_free() which is passing
> a bogus value. There is no "bpf_filter" defined in this application;
> it ends up being a text address inside pcap library.
>
> Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Cc: stable@dpdk.org
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-21 13:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20 22:18 [PATCH] dumpcap: remove bogus rte_free() Stephen Hemminger
2022-10-21 13:06 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).