From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0318D43C27; Wed, 28 Feb 2024 14:16:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B11FB40A70; Wed, 28 Feb 2024 14:16:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 72FBD4003C for ; Wed, 28 Feb 2024 14:16:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709126191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T8g5ESKFgIg8MfvY2CrMFcgwfLad4bl0BpySyTikclA=; b=UdBCd1ajbhql69eZtWCxpgQ3wGM22ffskFcwTQkiF1YNsC7IUcTV7Ae2FwL/Wx3l6z6x4K m4g8Xl++fvvb7R8oUicIR8KwL5mY49qGp/HcGxNMYdS0gX+5xuTKrCwEbLRjEFewV4HlRC wqPWLbOU/DWvZiT7cNmHfwlYnJaSX+Q= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-AcaOQ_5vO262omQXpT8PBw-1; Wed, 28 Feb 2024 08:16:28 -0500 X-MC-Unique: AcaOQ_5vO262omQXpT8PBw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d2bac6e205so8105521fa.0 for ; Wed, 28 Feb 2024 05:16:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709126187; x=1709730987; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T8g5ESKFgIg8MfvY2CrMFcgwfLad4bl0BpySyTikclA=; b=rlpszYvhbjtnd22L8RMT+UUE2ut896IFloj/4CYMNDrgJpF400WBlAKlfKR8ONyfOU IQxslVekzeg1rVVBgCCHuXKgKam1vT+yUQm5bukCQ+XgtuLDTXiso5jBE5Ml/50eN+rL dkXwItSqi+YmV8thaquKDFc0QD0argEJa0fJPlcxM0s578mTNygUdby6imx50nTSOdX3 CdAxyek9lkhonfbe+bJl5Z7A4feMeWlkoy59e4Qrx3zyoNkGUkKaaJ8m3SHGMe+vHg3r 9RN+lZ+tu+tAfTnShMMYRpKFxwvCTBILTUWkJm30FOiqXG7GGM7Kjzq8d57r2TobW4jJ alsA== X-Gm-Message-State: AOJu0YyvcnC1NIHEJzCj+/zUHDmeEwG7XvjkM6xhgI0DU3aHfjrlCgTp uIvU8Q0HgairNJAxq5nHXt3bLcfimKF4wPOyV3I4z04135sUa7Vq2vwV+12S2CnvpBBhEW8vDDo GON97gFxw0VlUSuvQUoI2Q/Ej7d4CINWAcvB4vijYjBfkYz8Ud0FTl7BooSL0yOCzIgCErA39jH Rfq7d96/UzsOqHGmM= X-Received: by 2002:a19:5518:0:b0:513:1cbd:572e with SMTP id n24-20020a195518000000b005131cbd572emr778730lfe.33.1709126187471; Wed, 28 Feb 2024 05:16:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGb//xYqT2P+9iWF2BoG0xe+lzyZAGATAI55a2Ks3gzLfO8vvlvusC9Lb0VDmYaX810UMVyYp79eqhTQtR686Y= X-Received: by 2002:a19:5518:0:b0:513:1cbd:572e with SMTP id n24-20020a195518000000b005131cbd572emr778698lfe.33.1709126187188; Wed, 28 Feb 2024 05:16:27 -0800 (PST) MIME-Version: 1.0 References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> <1708978786-6740-1-git-send-email-roretzla@linux.microsoft.com> <1708978786-6740-3-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1708978786-6740-3-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Wed, 28 Feb 2024 14:16:15 +0100 Message-ID: Subject: Re: [PATCH v3 02/16] bpf: stop using variadic argument pack extension To: Tyler Retzlaff , Konstantin Ananyev Cc: dev@dpdk.org, Anatoly Burakov , Ashish Gupta , Chenbo Xia , Cristian Dumitrescu , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Maxime Coquelin , Reshma Pattan , Sachin Saxena , Sivaprasad Tummala , Srikanth Yalavarthi , Stephen Hemminger , Sunil Kumar Kori , bruce.richardson@intel.com, mb@smartsharesystems.com, thomas@monjalon.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 26, 2024 at 9:20=E2=80=AFPM Tyler Retzlaff wrote: > > Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions > which allow a prefix and arguments to be inserted into the log line > without the need to use the ## args variadic argument pack extension. > > Signed-off-by: Tyler Retzlaff > --- > lib/bpf/bpf_impl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/bpf/bpf_impl.h b/lib/bpf/bpf_impl.h > index 1a3d97d..680b1e5 100644 > --- a/lib/bpf/bpf_impl.h > +++ b/lib/bpf/bpf_impl.h > @@ -29,8 +29,8 @@ struct rte_bpf { > extern int rte_bpf_logtype; > #define RTE_LOGTYPE_BPF rte_bpf_logtype > > -#define RTE_BPF_LOG_LINE(lvl, fmt, args...) \ > - RTE_LOG_LINE(lvl, BPF, fmt, ##args) > +#define RTE_BPF_LOG_LINE(level, ...) \ > + RTE_LOG_LINE_PREFIX(level, BPF, "%s(): ", __func__, __VA_ARGS__) The patch $topic seems to be removal of variadic argument extension. So, I would expect a simple: +#define RTE_BPF_LOG_LINE(level, ...) \ + RTE_LOG_LINE(level, BPF, __VA_ARGS__) Konstantin, just to be sure, are you ok with this (debug from my pov) prefix addition? --=20 David Marchand