From: David Marchand <david.marchand@redhat.com>
To: Vamsi Attunuru <vattunuru@marvell.com>, Jerin Jacob <jerinj@marvell.com>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>, dev <dev@dpdk.org>,
Kiran Kumar K <kirankumark@marvell.com>,
Igor Ryzhov <iryzhov@nfware.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA
Date: Wed, 20 Nov 2019 18:28:46 +0100 [thread overview]
Message-ID: <CAJFAV8xSAALpTFk-6GWD+XeHV5khYBzg8Y_0mNOpbK+csaxHRQ@mail.gmail.com> (raw)
In-Reply-To: <20191120172227.42798-1-ferruh.yigit@intel.com>
On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> A build error reported related to the selected
> 'get_user_pages_remote()' kernel API:
>
> .../kernel/linux/kni/kni_dev.h:113:8:
> error: too few arguments to function ‘get_user_pages_remote’
> ret = get_user_pages_remote(tsk, tsk->mm, iova, 1
> ^~~~~~~~~~~~~~~~~~~~~
>
> Currently there are three version of the 'get_user_pages_remote()'
> supported, based on kernel version
> < 4.9, = 4.9, > 4.9
>
> These version based checks are not working fine with the distro kernels
> which is the cause of reported build error. The error reported by the
> kernel version 4.8, but it is using API defined in > 4.9.
>
> To be able to take control of this, and possible more, related build
> error, increasing the minimum supported kernel version for iova=va with
> KNI to kernel version 4.9.
>
> This leaves us with single version of the kernel API and more
> manageable.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Jerin, Vamsi,
Is this okay for you?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2019-11-20 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 16:00 [dpdk-dev] [PATCH] " Ferruh Yigit
2019-11-20 16:24 ` Igor Ryzhov
2019-11-20 16:26 ` Ferruh Yigit
2019-11-20 17:22 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2019-11-20 17:28 ` David Marchand [this message]
2019-11-20 22:30 ` David Marchand
2019-11-28 10:44 ` Andrew Rybchenko
2019-11-28 10:50 ` Thomas Monjalon
2019-11-28 11:01 ` Jerin Jacob
2019-11-28 11:02 ` David Marchand
2019-11-28 11:05 ` Ferruh Yigit
2019-11-21 1:58 ` Jerin Jacob
2019-11-21 2:18 ` [dpdk-dev] [EXT] " Vamsi Krishna Attunuru
2019-11-28 12:13 ` [dpdk-dev] " Ferruh Yigit
2019-11-28 14:58 ` [dpdk-dev] [EXT] " Vamsi Krishna Attunuru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xSAALpTFk-6GWD+XeHV5khYBzg8Y_0mNOpbK+csaxHRQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=iryzhov@nfware.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=kirankumark@marvell.com \
--cc=marko.kovacevic@intel.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).