From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D63EEA04B7; Wed, 14 Oct 2020 12:36:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B51391DDEF; Wed, 14 Oct 2020 12:36:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id B94971DB6A for ; Wed, 14 Oct 2020 12:36:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602671762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i25I0nPuL3ixZXPR2o8mlNYVVnJSdbXsQb/iCzpvnRg=; b=XuVVmTjXTekC4ubfuD1tKQBZQXiRC4s9PHrezbKM+x5T63S3bDZtSCfxmhBMWFQwvHdURi TnstTscm85yvwoFQ4324G2LzP6w9Tn2WTEO53CsJhkFkOD5fWShowCGlFLFIRS1prC0raO bZqltxqMyksCEy66zgqwFI5pqlu59cg= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-gTgxXrgwNxulMXTpCUl6OA-1; Wed, 14 Oct 2020 06:36:00 -0400 X-MC-Unique: gTgxXrgwNxulMXTpCUl6OA-1 Received: by mail-vk1-f200.google.com with SMTP id t77so572425vkt.18 for ; Wed, 14 Oct 2020 03:36:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i25I0nPuL3ixZXPR2o8mlNYVVnJSdbXsQb/iCzpvnRg=; b=DpdDBlOnSnNpwKQc4YyG1JJcOaPZtsjeGBxxklktdWuFpFWxzrIRTNVcVGtqhLGc2s cX4Yrrq2h02cdw8eZjQPLtunlnFUwHcOvzcD1tjpHfxTJ1oBwXzV7WIGhCyMteAmic2k 00F/6U8jkJ/mSvtQa5xfWzqTfK332xinusdchuYAXVcueQRDio8XBddIWxc+zcmFtsjA Ykewcclsb6oSdiIzY/AsKhoN6jI/Mh/8BKSlEDr7WwCgz2No8okhN2KUriDvoygtRM7h WTsV0A+3SW8Z8yabmrUEJwwLu9ACZ/Z6gLgxxjjwvFaDuoYKV3W6XkSfk2ZF7lsyJykP nFZA== X-Gm-Message-State: AOAM531uPiVRiJ1OV8nHKk6NO0v91L/93m1g8JJKn4CvXLYR6m0k6lw+ noEa3ykEGTe95PIvVGiWQiXX71jlaAqhvicpbIryJkNylQbB9fC6NIF/mNCB7RiguOBBvGojZLR AMhl7zt2C00m6NcUbhmE= X-Received: by 2002:a67:68c9:: with SMTP id d192mr2660460vsc.5.1602671759802; Wed, 14 Oct 2020 03:35:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoU6u09HFpEvWAU3aE158cBlnyHCqV4yFmeNMVwob3lf2FHDP1RLDAWAJZwh6Y48VrvyoPRjooMfWytqkiDlk= X-Received: by 2002:a67:68c9:: with SMTP id d192mr2660448vsc.5.1602671759549; Wed, 14 Oct 2020 03:35:59 -0700 (PDT) MIME-Version: 1.0 References: <20201005184526.7465-1-konstantin.ananyev@intel.com> <20201006150316.5776-1-konstantin.ananyev@intel.com> <20201006150316.5776-14-konstantin.ananyev@intel.com> In-Reply-To: From: David Marchand Date: Wed, 14 Oct 2020 12:35:48 +0200 Message-ID: To: "Ananyev, Konstantin" Cc: dev , Jerin Jacob Kollanukkaran , "Ruifeng Wang (Arm Technology China)" , "Medvedkin, Vladimir" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 13/14] test/acl: add AVX512 classify support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 14, 2020 at 12:32 PM Ananyev, Konstantin wrote: > > On Tue, Oct 6, 2020 at 5:13 PM Konstantin Ananyev > > wrote: > > > > > > Add AVX512 classify to the test coverage. > > > > > > Signed-off-by: Konstantin Ananyev > > > --- > > > app/test/test_acl.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/app/test/test_acl.c b/app/test/test_acl.c > > > index 333b347579..5b32347954 100644 > > > --- a/app/test/test_acl.c > > > +++ b/app/test/test_acl.c > > > @@ -278,8 +278,8 @@ test_classify_alg(struct rte_acl_ctx *acx, struct ipv4_7tuple test_data[], > > > > > > /* set given classify alg, skip test if alg is not supported */ > > > ret = rte_acl_set_ctx_classify(acx, alg); > > > - if (ret == -ENOTSUP) > > > - return 0; > > > + if (ret != 0) > > > + return (ret == -ENOTSUP) ? 0 : ret; > > > > Does this really belong to this patch? > > I would expect it in "test/acl: expand classify test coverage". > > Yes, you right. > Do you want me to re-spin? No need for this, thanks. -- David Marchand