From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA8D6A0C45; Wed, 20 Oct 2021 09:03:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFFCA41167; Wed, 20 Oct 2021 09:03:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4F0E241165 for ; Wed, 20 Oct 2021 09:03:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634713410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pMp7QDzNiDAuV8tJh56Ytmljv/1t1H40692Nl4Y8MyI=; b=ITdtOUs2CVjRKIPizUTPsLG2F3Ye9IMfjhbEQllV3zBmoeyPV3jLYtFF7KSbQnyfVl4zG9 x0776Gi4GVgakDIWR4rjiLWlBbSDkojr3ukxf+2VAEVB6ijoq++DVUuoJ5pZtJBFJtd1L9 YksPTpDoQmRv1VA/780U36JfZ+z0hrU= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-HTd_lBlUNfWSrg4kCPOzaQ-1; Wed, 20 Oct 2021 03:03:27 -0400 X-MC-Unique: HTd_lBlUNfWSrg4kCPOzaQ-1 Received: by mail-lf1-f69.google.com with SMTP id d12-20020a0565123d0c00b003fdb52f1cdcso2728557lfv.4 for ; Wed, 20 Oct 2021 00:03:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pMp7QDzNiDAuV8tJh56Ytmljv/1t1H40692Nl4Y8MyI=; b=nca2JMAk6kzrthxMjfcO4xqoq3Ahwbg1KoTToL7rObHArsKbXXvsgHINrUJUXP/MUw xWOwWzgnQjIlMwTLBvz3kYN3XttAmQ5novv7zTYlwrf6XosyMQXalKy6L7ynt7hsxZ/j S/PHRE4cWxb3FwJRmAFLphYLEpopfSC1dnSZRCEmYFAh9/vH6k3YcYNqSjI+/okB/+QP dXGfz4Bw3SCeNsY7yydn3uwFvvgq6x0/dPNQGunhdbrMiPWaSR7PZq2ch7FVT+wk0Htb 1EDEL9t49fyZ7Wn6gRPAWCUBENfY+wSokL2LEoypVhAXMS4HEPMldR1TES2wAZhhjOl1 uI5g== X-Gm-Message-State: AOAM532d1SI6npy6PtWsw8PLBrJ2cjxplGBVsNvnRq6S/SIc+mKvqBhh triE5zgFeIrEuVU9sAidQEnYduwFNCFfziQeMZhttmw7aKuddTMSbE5HaOOdeoeLBRSdYXSuHcs xgwAdwSHW/n4Et3pgXag= X-Received: by 2002:a05:6512:202a:: with SMTP id s10mr10151276lfs.560.1634713406153; Wed, 20 Oct 2021 00:03:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzR9uoxLgR4+WYIFkN/LRtvVHZh9W7mNTbMwtUZTz5YJL7vwq+tBJxF9J9odE4igzPuRlrO/M+tlUrbOzKIkVM= X-Received: by 2002:a05:6512:202a:: with SMTP id s10mr10151265lfs.560.1634713405993; Wed, 20 Oct 2021 00:03:25 -0700 (PDT) MIME-Version: 1.0 References: <20211019122800.1537505-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Wed, 20 Oct 2021 09:03:14 +0200 Message-ID: To: Bruce Richardson , Chengwen Feng Cc: dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] dmadev: enable build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 20, 2021 at 8:32 AM David Marchand wrote: > > On Tue, Oct 19, 2021 at 2:28 PM Bruce Richardson > wrote: > > > > The dmadev library was not added to the list of libraries built on > > Windows, meaning it was skipped in those builds and also that none of > > the drivers were being considered for build. Adding dmadev to the list > > fixes this, and also enables the skeleton dmadev driver to be built - > > all-be-it with a small fix necessary. > > > > Signed-off-by: Bruce Richardson > > --- > > > > This patch has been compile tested using mingw on Linux. Sending it > > publicly so that I can get CI test reports to check native windows > > builds. > > --- > > There is a problem with exported symbols. > Some inlines have been marked for versioning (see > rte_dma_burst_capacity for example) and must be removed from > version.map. > > Can you have a look? I sent the patches. Hope it saves us some time: https://patchwork.dpdk.org/project/dpdk/patch/20211020065944.19617-2-david.marchand@redhat.com/ -- David Marchand