From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F30A042651; Wed, 27 Sep 2023 11:38:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7BEB402DC; Wed, 27 Sep 2023 11:38:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 36D4C4026B for ; Wed, 27 Sep 2023 11:38:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695807523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2QezGrzhy8uEudfb8p011OJDo10l5h3KUNWc2G3ZYXE=; b=cwHhB0gWCPnY8B22Rrly4Lg51PHohPqB80k30hb5jTcPup9ZYaDfU9AAy5ZZBPk9Y8fvfZ jOO1Y4NSrfLbUm8xRXfFw1m3kd9x1rEgjZi6YX7vfOXOMceA4nVJH6QY/VoI1PclzREJ4x DxjCbW2oiWFgsVFuyM616SXlqrgVKgo= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-GgB0Sj-0Ni2eJjFPQfvKig-1; Wed, 27 Sep 2023 05:38:42 -0400 X-MC-Unique: GgB0Sj-0Ni2eJjFPQfvKig-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c038a1e2f6so168327311fa.3 for ; Wed, 27 Sep 2023 02:38:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695807521; x=1696412321; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2QezGrzhy8uEudfb8p011OJDo10l5h3KUNWc2G3ZYXE=; b=HMcDddHzIwjQ6lo+AzYUc4Swt+mDHH0DFucInJBuobaxUbr04PrqlrHcstxSzGcsDo bRCB+gVPxzGGAyUcV4GJKq4aEJzxHoAU14rEqaMV+xqFFdH7W2yR9PQn7IQdKwhh2BQA CfDGVhVMZuYwCwDnzxjfHmEVhU6V3hz59TjBOcVj0gCmJR2rJIGH/zmk49NwgxupJQp1 qNVULT1HrKaOQpGfG93JnBgcVwxHnI5pEcgVHhRQKw4CZGGvTAEP1dVYq5UuDo31JxqN vn4ZwGF2xypQQ4iu8dDk94CjMzAZB5NwS5aSJoiH8iuXG5u6znDU9UfTBuSL6o8pG9uU 4TYg== X-Gm-Message-State: AOJu0YxT7bI50ZaDwR1LMSbp92ol0x8mhz0fgsx3Q7HXxhtkN0uRJv7o EFYBXeuZWAp+EplEJCmC1sGlhYRrEy6mAoSlFyPvVx6IRJCC2KkLU/IkT4J41zQaYkZZLFBLn3U XR45j3FlJHDdv5fvCL78= X-Received: by 2002:a2e:3812:0:b0:2bc:f28f:9147 with SMTP id f18-20020a2e3812000000b002bcf28f9147mr1354874lja.48.1695807520831; Wed, 27 Sep 2023 02:38:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbhVU6jKvu+KbSCYTv3zuNbJmEe07vIdcQhu1QY3Rs7hXV4DcCSKjH+j29cmfWXq3EbCkHULO/5La3VDFbqnA= X-Received: by 2002:a2e:3812:0:b0:2bc:f28f:9147 with SMTP id f18-20020a2e3812000000b002bcf28f9147mr1354855lja.48.1695807520470; Wed, 27 Sep 2023 02:38:40 -0700 (PDT) MIME-Version: 1.0 References: <20230830155927.3566-1-syalavarthi@marvell.com> <20230830155927.3566-3-syalavarthi@marvell.com> In-Reply-To: From: David Marchand Date: Wed, 27 Sep 2023 11:38:29 +0200 Message-ID: Subject: Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for firmware read To: Jerin Jacob Cc: Srikanth Yalavarthi , Prince Takkar , dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 21, 2023 at 2:08=E2=80=AFPM Jerin Jacob = wrote: > > On Wed, Aug 30, 2023 at 9:40=E2=80=AFPM Srikanth Yalavarthi > wrote: > > > > Dropped use of rte_firmware_read API to read ML firmware > > binary. When DPDK is built with libarchive aaupport, the > > the RTE API assumes the binary file as a compressed > > archive. This causes the ML firmware binary to be parsed > > incorrectly. > > + @David Marchand rte_firmware_read() author for his opinions I am not sure if this series was applied, but this patch can be discarded as a fix on rte_firmware_read has been merged in the main repository. Thanks for the heads up Jerin. --=20 David Marchand