From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C064A00BE; Mon, 4 May 2020 16:17:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACB411D16B; Mon, 4 May 2020 16:17:43 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id CB9DD1D167 for ; Mon, 4 May 2020 16:17:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588601861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ab7IL4rOpLrCup62+D5TLkXJuQqC97/q8g/jFi20ZLg=; b=KZ1ssyaKzTjM6Jz9J2KpxoIOkZy+WKJBxtMP5WlAD+3fgxlPT8xd0th/HjDggTvXKdWyJC V9q4duzqfJFiTTdePnSjibZqvgGXUwwFatdnSK4H2pN0oki+D/6ipWRH1H5bcIJrhV/P3n l6PNXzEzr8wAplUbfva58Lgc2jd+vkU= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-9eawAe9eNS26XFoYwfimLQ-1; Mon, 04 May 2020 10:17:39 -0400 X-MC-Unique: 9eawAe9eNS26XFoYwfimLQ-1 Received: by mail-vk1-f198.google.com with SMTP id s81so9060093vkb.16 for ; Mon, 04 May 2020 07:17:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x8nUR2tPhN32oVXgU/1MXk3ksMnNDbT+Gf+WOkH1hgs=; b=cSf8L3LosA9rRKmGaS9wS44pA7ypw8llASRdJYMQWEPkgmNWBOB9HubK3cv4DTGzsf PQml8WSZwEI0lQLq5tU1nwpK7QYqlwkTCsIyz8BvSpdJXGqGgMDsg8TqV5FJMTQgK64k zhIZQPvRHzUuINJGCS+BJztnW1DU6XpIqNVODa253C1ZPDdbFJv90u1srs78jmBqK6nP bzNYjN/xAaCx0uUcrEaHpD2H9dBBYTh32zUAUVzizG9Wg1QcuO3ySBiysKpitHcH5P03 dVjFu1RWdzQpL6vFfWuUQX5aajFUIOIZPXvJPvKw7kdVAHAkTIobUljTDR7wVeyydmZs Qiiw== X-Gm-Message-State: AGi0Pua1LyVGzjFM7YuFvPf5hKpoaUK3lAW8pUnSTJtd5DFM67k+8EBI 204SjdDdPkAIfCSswl1ftqSfrhH+jNolY8PtY2ENjMoOY2YRQKDIkCrDdXfQqOcDI/FtQ8Y7UPP TWpmj5TZAKaR/hn/YtBc= X-Received: by 2002:a67:d817:: with SMTP id e23mr12026453vsj.39.1588601858809; Mon, 04 May 2020 07:17:38 -0700 (PDT) X-Google-Smtp-Source: APiQypKyzSmlalMjIuunYlLX57EaOUuqfc1DCE7gmUXKRn725BLjPb9jXk7WfdfaC0xZTe10Zml0IIM9qhdc+HVWv+I= X-Received: by 2002:a67:d817:: with SMTP id e23mr12026413vsj.39.1588601858341; Mon, 04 May 2020 07:17:38 -0700 (PDT) MIME-Version: 1.0 References: <20200501113909.26355-1-skori@marvell.com> <20200502074205.29080-1-skori@marvell.com> In-Reply-To: <20200502074205.29080-1-skori@marvell.com> From: David Marchand Date: Mon, 4 May 2020 16:17:27 +0200 Message-ID: To: Sunil Kumar Kori , Gaetan Rivet Cc: Stephen Hemminger , Jerin Jacob Kollanukkaran , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v5 1/1] bus/pci: optimise scanning with whitelist/blacklist X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, May 2, 2020 at 9:42 AM Sunil Kumar Kori wrote: > diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h > index a205d4d9f..3a9da7322 100644 > --- a/drivers/bus/pci/private.h > +++ b/drivers/bus/pci/private.h > @@ -42,6 +42,17 @@ int rte_pci_scan(void); > void > pci_name_set(struct rte_pci_device *dev); > > +/** > + * Validate whether a device with given pci address should be ignored or= not. > + * > + * @param pci_addr > + * PCI address of device to be validated > + * @return > + * 1: if device is to be ignored, > + * 0: if device is to be scanned, true/false > + */ > +bool rte_pci_ignore_device(const struct rte_pci_addr *pci_addr); Gaetan, private API must not be prefixed with rte_, this is for public APIs only. I noticed inconsistencies in the pci bus some time ago, I will fix this patch for now and send some followup patches I had in store. > + > /** > * Add a PCI device to the PCI Bus (append to PCI Device list). This fun= ction > * also updates the bus references of the PCI Device (and the generic de= vice Sunil, no need to send a new version, I will fix this when applying. Thanks. --=20 David Marchand