From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EF7EA046B for ; Sat, 29 Jun 2019 07:57:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D9F5326D; Sat, 29 Jun 2019 07:57:51 +0200 (CEST) Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by dpdk.org (Postfix) with ESMTP id 262A7325F for ; Sat, 29 Jun 2019 07:57:49 +0200 (CEST) Received: by mail-ua1-f52.google.com with SMTP id a97so3025380uaa.9 for ; Fri, 28 Jun 2019 22:57:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DUkN/N0i7Yu265DKk37QNowI1q6VRLVojFhQ7R13wEo=; b=Srk+w9wLpAgwdxpTd/9Nyzb5DAt7kXssIkMn4pllPO1sM4JK+PCIv/f3N2vVLuNOJr AVePLnVaIU0PYRAfusT8r6UkC0+EV+vJJm9IcX8Ys6UpXK7FZ5t5DSD0690N03YDxFTd nv2GfdRgeO3a6we9NycPo2zvBuLSOtSAJVowVc4AyNZFLg5cTGdmH74hV10qi7m2JwwH VlDycOAS0mOlxp6B3Jv/SR+NGCuCxK4GyMjg+8LQbkvsaOvkv2MH/IGvM5d6s4oNBXib SufVejv5OfbjVfJ/d4ms/sF2J1qqjZcdw/4KPGoQ52yOjUwbXoo2w9J7sPtSfdoiNjcC 4kRg== X-Gm-Message-State: APjAAAVWkSRaTkZ7ZPk5x1KCDvm1KVQZz6OcZmqdnrQ9Jp35A4PXWG4c FG3EZ//lOkDzR6wSdCDpUFE30bsvna5WaJiV9vxrag== X-Google-Smtp-Source: APXvYqyqYu4m+k0h5zkGP5m7401DZ3e7QbY8tnZrt87FCgQ88eT6A/0/d3f9W6a6gW+0/cEm80qsYV+wnhxhV/WtXQs= X-Received: by 2002:ab0:6198:: with SMTP id h24mr2459591uan.41.1561787868589; Fri, 28 Jun 2019 22:57:48 -0700 (PDT) MIME-Version: 1.0 References: <1561635235-22238-1-git-send-email-david.marchand@redhat.com> <1561635235-22238-9-git-send-email-david.marchand@redhat.com> <2284715.k64COaWSDv@xps> In-Reply-To: From: David Marchand Date: Sat, 29 Jun 2019 07:57:37 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Neil Horman , Aaron Conole , John McNamara , Marko Kovacevic , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Konstantin Ananyev , Amr Mokhtar , Fiona Trahe , Pablo de Lara , Ashish Gupta , Declan Doherty , Anatoly Burakov , Harry van Haaren , Bruce Richardson , Ferruh Yigit , Andrew Rybchenko , Adrien Mazarguil , Cristian Dumitrescu , Nikhil Rao , Jerin Jacob , Bernard Iremonger , Yipeng Wang , Sameh Gobriel , Olivier Matz , David Hunt , Honnappa Nagarahalli , Akhil Goyal , Kevin Laatz , Robert Sanford , Erik Gabriel Carrillo , Maxime Coquelin , Tiwei Bie , Zhihong Wang Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 8/9] remove experimental tags from all symbol definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 28, 2019 at 9:20 PM David Marchand wrote: > > On Fri, Jun 28, 2019 at 5:57 PM Thomas Monjalon > wrote: > >> 27/06/2019 13:33, David Marchand: >> > We had some inconsistencies between functions prototypes and actual >> > definitions. >> > Let's avoid this by only adding the experimental tag to the prototypes. >> > Tests with gcc and clang show it is enough. >> > >> > git grep -l __rte_experimental |grep \.c$ |while read file; do >> > sed -i -e '/^__rte_experimental$/d' $file; >> > sed -i -e 's/ *__rte_experimental//' $file; >> > sed -i -e 's/__rte_experimental *//' $file; >> > done >> >> There is one miss: >> >> rte_telemetry_parse is not flagged as experimental >> but is listed in version map >> Please add __rte_experimental to the definition of rte_telemetry_parse >> > > Not sure I get you. > How did you get this warning? > > Ah ok, this library is disabled by default. Another fix being cooked. Expect a v2 maybe later today, but I still need an answer on which approach we take :-) -- David Marchand