From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBDA545C15; Wed, 30 Oct 2024 15:55:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B45B9433DA; Wed, 30 Oct 2024 15:55:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7BFC0402EE for ; Wed, 30 Oct 2024 15:55:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730300142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ksE1t32VKQYw8aBPgKWEqrLt5JCaYYpeBqV23i6xfFw=; b=BOQ4Waa3HD0NTFJPprJBlZ5PhHCwXZ8vmWy/Y9GZFPJYGu3nTQgghKeg32r5/jwuiQyBNt MhsswPP5CsTrBgBNwcOBO3lEfNvz6ot2NQu/clpU0lwinDz7CB7MTNiqPVK11MZGPB7Xf2 5dhrAf5yKa9WHwfAB+qPoTGKSUFql4I= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-ZcxGEwDKMZyjjRBnOjyoSA-1; Wed, 30 Oct 2024 10:55:41 -0400 X-MC-Unique: ZcxGEwDKMZyjjRBnOjyoSA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2fb50ced198so46598941fa.1 for ; Wed, 30 Oct 2024 07:55:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730300140; x=1730904940; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ksE1t32VKQYw8aBPgKWEqrLt5JCaYYpeBqV23i6xfFw=; b=obAOLEOlmQIyy0+U+c/uL45GVpYOGfnP1RgkYyrgpUkY/oHhoXN5U5UFJ6CkTA7KgF 93I37noYyppdiSW8e5eoS6+cAuqEilLDb98iM0yiqFOeQWFvhfwPwXScTD0dxraXzcM0 d4/3DhktfZ+prx5kfBeIf7vzFg+iEEcbMXhkgLRXKsheCyRiiHz6IEuaZxNzGDHwYJOw S+jS1ylznD/IX+XP+q6fO7b3wWBNDiH3Z1YJSlLgXRuCcHX5/cA640uhuQriT5SX8yI+ NMBcSlBafgbpydvgHwJ8sQI8mg+YeXIlUWl/PWx4cUXXHCjaxc7FInuuFhmPjwkanoy/ GYrQ== X-Gm-Message-State: AOJu0YxuqkMwiX84qsB/o5/Xjxh5dXIF+ZC99l3EdyYGta/gnd5EVHod dngOa7nRbKRO1LDQeS/IR5CzTHOOfpSBOpEx0LM6QUviikiMj+EEH16OFh6cmAKNDfefcWmRHtt z3XebzYTR/1B7jtQTTF8xP7QxM0s+ApLHI2V4FyVs+5M1ZUYPX+e7j3DAPqc7ErfhjZZbpKCJRL AkksVMwn5G163Y1cY= X-Received: by 2002:a05:651c:2112:b0:2fb:59ab:a0ed with SMTP id 38308e7fff4ca-2fcbdf61b32mr76222441fa.3.1730300139898; Wed, 30 Oct 2024 07:55:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBFx91oEaBu9mBXX/dQfGzE1U+Yp8VqGna2zQEsrqQueGeMgfvxXgxJdrmGNONGwQtR9K1VnYRcywLl5jToCQ= X-Received: by 2002:a05:651c:2112:b0:2fb:59ab:a0ed with SMTP id 38308e7fff4ca-2fcbdf61b32mr76222281fa.3.1730300139523; Wed, 30 Oct 2024 07:55:39 -0700 (PDT) MIME-Version: 1.0 References: <20241022122042.2127065-2-wang.junlong1@zte.com.cn> <20241030090124.2540776-1-wang.junlong1@zte.com.cn> <20241030090124.2540776-4-wang.junlong1@zte.com.cn> In-Reply-To: <20241030090124.2540776-4-wang.junlong1@zte.com.cn> From: David Marchand Date: Wed, 30 Oct 2024 15:55:28 +0100 Message-ID: Subject: Re: [PATCH v8 3/9] net/zxdh: add zxdh device pci init implementation To: Junlong Wang Cc: dev@dpdk.org, wang.yong19@zte.com.cn, Maxime Coquelin , Stephen Hemminger , Thomas Monjalon , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 30, 2024 at 10:07=E2=80=AFAM Junlong Wang wrote: > > Add device pci init implementation, > to obtain PCI capability and read configuration, etc. This title with PCI intrigued me, so I had a look at this patch. Please use the PCI bus API and don't redefine common PCI constants/helpers. To make it easier for you, I recommend having a look at: $ git show a10b6e53fe baa9c55009 7bb1168d98 -- drivers/net/virtio/virtio_pc= i.c --=20 David Marchand