From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD3EE43B29; Wed, 14 Feb 2024 09:19:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A50CB40A7A; Wed, 14 Feb 2024 09:19:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 599F240263 for ; Wed, 14 Feb 2024 09:19:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707898780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P9lWDv+lBJDDkNXZh90KxKw89o+wy3/FNW4AFzsQewM=; b=LrQ4xgngKd/e/hFrZU9fL5JKCFBHlIsKA6ARd0ksltHRP+qkTwzWqFaYOtGUGvLhjbyygM Cxr+PdcjCXzWLB9kbzPE+RrQ0Nt5y2MAHNmD4YNrMcNCML7LHxfnYwpiToCojxCcHz3YlS EqC9pMp86yPYX+rxocHUF2xZPkcCNlo= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-VqRseroDMpaBAhcTIzmywg-1; Wed, 14 Feb 2024 03:19:39 -0500 X-MC-Unique: VqRseroDMpaBAhcTIzmywg-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5114a395d9cso293715e87.0 for ; Wed, 14 Feb 2024 00:19:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707898778; x=1708503578; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P9lWDv+lBJDDkNXZh90KxKw89o+wy3/FNW4AFzsQewM=; b=cgo2oA47b8g9VNbp0ZEHetiQ5L0gOYCJDEk6umMIs2Y7nMdbguzPOiK3RgVAyDeOm4 t+FnIJJgFmXyDv751Fy0znrugCmPq6L4Xxr1shW7N0e56IOT89AX/CVClhnCr0G/8Q2m aWbrPf9cXix+UFgF57t4GCfty7L+Tfck9K2gmQXChxL8r+bl4FwiQfuLllEDVL+e+HEu 4o6qHHxQwZ0+Eg/3jo3e8XA/fJYEB1HrIt0VznbXOfIrL/y1E0IpBDfNgGN4qbPLFIU+ E5qFLo8jJYRQAIkCNaf+fl8Ka2+8cYsPI3TJC/EPYvz+AMUJ/qkR1XxlguF3Vz4qjlfe H+9w== X-Gm-Message-State: AOJu0YxmJk0R+jOT9pOidPhcb/SxwRzESPuwiGgWbKxXYlOm0asCNkKA N7RvzfW/CVzwAwemzjzLqy0R9+o19B4yD8nHMt+X4U3n3anUiVZt4bV7ExZIgX7sWXhac8UzDq5 G+9YKK6lrg+14uwWUU0bbGTwYh6T5Ly9B/sW0nHYkXGJxD5B/LyYBNpqx4TGsVE0/6D4sqfcdTb mIeEcYgD/+INhCu00= X-Received: by 2002:ac2:43a4:0:b0:511:9cf4:b410 with SMTP id t4-20020ac243a4000000b005119cf4b410mr406320lfl.1.1707898777824; Wed, 14 Feb 2024 00:19:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IGoY3PD80WaNePIaAisdKGEXge/JZftUrF6t/QZUiOk8I0ITWok40jRrxJJ8DXorU0qdx4/eDOrgCyMN1UvQN0= X-Received: by 2002:ac2:43a4:0:b0:511:9cf4:b410 with SMTP id t4-20020ac243a4000000b005119cf4b410mr406306lfl.1.1707898777463; Wed, 14 Feb 2024 00:19:37 -0800 (PST) MIME-Version: 1.0 References: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com> <1707851523-27998-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1707851523-27998-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Wed, 14 Feb 2024 09:19:25 +0100 Message-ID: Subject: Re: [PATCH v3 0/3] remove __typeof__ from expansion of per lcore macros To: Tyler Retzlaff Cc: dev@dpdk.org, Kai Ji , Pablo de Lara , bruce.richardson@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 13, 2024 at 8:12=E2=80=AFPM Tyler Retzlaff wrote: > > The design of the macros requires a type to be provided to the macro. > > By expanding the type parameter inside of typeof it also inadvertently > allows an expression to be used which appears not to have been intended > after evaluating the parameter name and existing macro use. > > Technically this is an API break but only for applications that were > using these macros outside of the original design intent. > > v3: > * provide notice in release_24_03.rst about change in macro > expansion. > v2: > * add additional patch to adjust usage for crypto/ipsec_mb > > Tyler Retzlaff (3): > eal: provide type to per lcore macro > crypto/ipsec_mb: provide type to per lcore macro > eal: remove typeof from per lcore macros > > doc/guides/rel_notes/release_24_03.rst | 5 +++++ > drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h | 2 +- > lib/eal/common/eal_common_errno.c | 2 +- > lib/eal/include/rte_per_lcore.h | 8 ++++---- > 4 files changed, 11 insertions(+), 6 deletions(-) Thanks Tyler. Series applied. --=20 David Marchand