From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42479A04A5; Wed, 17 Jun 2020 12:02:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C5D91252; Wed, 17 Jun 2020 12:02:41 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 9B3E1FFA for ; Wed, 17 Jun 2020 12:02:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592388159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I0UoWrU1+pVjnI+i7MZelB83uh55YFCPCjoXTZAJKrY=; b=QlDKl0szXjVZDkMbPtOB2cJRVSKOOii0FM0YJsvSgGJfJFuQzKOU8P6uLFITdw1VLzwhYa 7O7I4L9EkNGLGTAIuf50TXnphxwZAvQmdEWAFG5d5xuUZD3U9GRIUDiBR9AV6QAu4TEOWA 8Vlihdnb7SBJWGb/TseWv1V6iC8FIH4= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-137-jBphwD4cPsa6ZN0bwzMXrw-1; Wed, 17 Jun 2020 06:02:37 -0400 X-MC-Unique: jBphwD4cPsa6ZN0bwzMXrw-1 Received: by mail-ua1-f70.google.com with SMTP id a20so729047uao.19 for ; Wed, 17 Jun 2020 03:02:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I0UoWrU1+pVjnI+i7MZelB83uh55YFCPCjoXTZAJKrY=; b=PQ4+C+UBqSZdMQzOAkamV2QpD21iQvwv4p3/Wp2OVZXGPCLsGJCQq0J1o1JyCV0zdm WxErSpOnJm+gntzFJQhnk9E01sA65AM8BkBXgoGQx5+3j/r8iwmK6tJY4/8f7EjVJc11 zkDUsiy6l0juSuqKMLo/wnnT+A/dzDsFgFr8cXgB+85oduYUEfJXGTGubtZWnUGGHToj 8SG/sQDX00ib3AhkxrRFp0oZ+/JHHc+c9+HkYBskxqh4LLdWSxZBco2GLvOvJg5y2hxZ rUrAwTHwOtqUIfU1GOZGsAU6FCQcUuNG+UxkzMlzVvUYqxsg92Sw/y6uYtQJQQq5Rjr7 b5JQ== X-Gm-Message-State: AOAM531IvFbpNaIwaMaS0JbFWvoRmMXvTri4wNP23SfgS6vTj8hn9WMQ Zi03BmrR+s6Ut8m+b299de6892vaM1zn9pnHTlazIpWNkrDL6kXegRUgkd12n6kDYysajZ+9b0v Fdai10GLyIEgWS3P70P8= X-Received: by 2002:a67:b741:: with SMTP id l1mr4971947vsh.180.1592388157076; Wed, 17 Jun 2020 03:02:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEJE2zhkcSAT+bfupPKpptd6kvoWR0shAoIjmRQlS7b9BryFvyE+X8OSXNqBMtLQXeOJ+9ZuEry4+477f4l78= X-Received: by 2002:a67:b741:: with SMTP id l1mr4971925vsh.180.1592388156778; Wed, 17 Jun 2020 03:02:36 -0700 (PDT) MIME-Version: 1.0 References: <20200617063047.1555518-1-jerinj@marvell.com> <20200617063047.1555518-2-jerinj@marvell.com> In-Reply-To: <20200617063047.1555518-2-jerinj@marvell.com> From: David Marchand Date: Wed, 17 Jun 2020 12:02:25 +0200 Message-ID: To: Jerin Jacob Kollanukkaran Cc: dev , Thomas Monjalon , Olivier Matz X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 17, 2020 at 8:30 AM wrote: > > From: Jerin Jacob > > Introducing the RTE_LOG_REGISTER macro to avoid the code duplication > in the log registration process. > > It is a wrapper macro for declaring the logtype, register the log and sets Having the logtype variable declared as part of the macro will force us to have global symbols (for the cases where it is needed). I'd rather leave the declaration to the caller, and only handle the registering part in this macro. > it's level in the constructor context. > -- David Marchand