From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24596A0546; Tue, 6 Apr 2021 22:10:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B639E406A2; Tue, 6 Apr 2021 22:10:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8E6B54067C for ; Tue, 6 Apr 2021 22:10:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617739808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h4dcOD+bRjLrt0jzBYQsOn3btT3PjyPG8kp3AFYUugc=; b=WUbc/0TzByy7o4MJ/YETJTm+ep4jqZKFJpFQqNyuKzFu3nfDjc8bGleJFzIBaHQFIsn/id d7C7vdM4VCyvNjCR26iueJJU2lwj0bYQ3UbPv0fqU1b6Kv3OdMwKDZcRHBc/RBjEVXezJX 3nw2z+/U3Ho165aJWouDgJ2+2p3SNSM= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152--hzUBP78NrGvZ0s5r8mrXg-1; Tue, 06 Apr 2021 16:10:06 -0400 X-MC-Unique: -hzUBP78NrGvZ0s5r8mrXg-1 Received: by mail-vk1-f197.google.com with SMTP id x23so5371048vkd.0 for ; Tue, 06 Apr 2021 13:10:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h4dcOD+bRjLrt0jzBYQsOn3btT3PjyPG8kp3AFYUugc=; b=a0kpESZboRDMp6jYdzOH8v422Q1aAUh2Nw+RMLShuh+D10llpKhqU/npjf+TPOX7QO QUZPG4/CP9BnA+tmALkIJ5DPWGXECYnd08ghcui7uX5JMP6M+OXWyMzJDm+j87R/ekhs BYwKXJBnfQPOXAhmpfhsqK5gA23IYof+ogQFf82vDdEAyTxokbSrdqhrkzUi5m4L39Bk sh3bH8KOGvkwEAM+766Zzx3xX6yk0OO9fwQ0jdU34rv6L/nkhgHSeHNaJrlsZHHhm3ZL E3fxHY9c+WdjIbWCf8bQrywRfXiHaQ2VglbKY3qCCBUZ3MfDcd/XdXp/eKzw9xf8g2Mx mAQw== X-Gm-Message-State: AOAM533oGMkE8725J8QFOVQiiLkXsH5XgIr7lquP6lrz1RH1hcJF4GAf needtx2BcB1v7ybzgTPQEXO0CKsdajIJTcl0dvoK3ibXnbfzz3fzNtvR4G6qV76Jeae5QSrSVSC KzvkVyBHAPqz1yhL9ic4= X-Received: by 2002:a67:f895:: with SMTP id h21mr41025vso.17.1617739805847; Tue, 06 Apr 2021 13:10:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYJ4vT/0DEXcqzubCf1tz6uwdxNNyY25temAT3nkfhS88gqBZE3VP//3dcLZlAccImXRS9PMn2Z6I01QC+Iyk= X-Received: by 2002:a67:f895:: with SMTP id h21mr41002vso.17.1617739805634; Tue, 06 Apr 2021 13:10:05 -0700 (PDT) MIME-Version: 1.0 References: <20210406163231.19663-1-david.marchand@redhat.com> <20210406175910.24450-1-david.marchand@redhat.com> <4303766.JfoNgE5a7G@thomas> In-Reply-To: <4303766.JfoNgE5a7G@thomas> From: David Marchand Date: Tue, 6 Apr 2021 22:09:54 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ray Kinsella , Neil Horman , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 6, 2021 at 8:53 PM Thomas Monjalon wrote: > > About the title, it is not a single file but one file per lib/driver. > I think it would better convey the idea by saying "remove .def files". Ok. > > 06/04/2021 19:59, David Marchand: > > Rather than have two files that keeps getting out of sync, let's > > annotate the version.map to generate the Windows export file. > > > > Note: Existing version.map annotation achieved with: > > $ for dir in lib/librte_eal drivers/common/mlx5; do > > ./buildtools/map-list-symbol.sh $dir/*.map | > > while read file version sym; do > > ! git grep -qw $sym $dir/*.def || continue; > > sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" $dir/*.map; > > done; > > done > > This patch keeps the exact same behaviour, right? I checked by sorting/diff'ing previously committed .def files for EAL and common/mlx5 with the newly generated ones. No difference, once aligning the mlx5 version.map. There is one change in behavior. I thought as exports.def being a subset of the map files, and this patch enforces it. It seems there were some tries at going the opposite way, looking at the comment in check-symbol-maps.sh. But looking at the current common/mlx5 state, I don't see this as a requirement (Linux and Windows share the same interface). > There are a lot of symbols in EAL and mlx5 which should > be exported for Windows too, but it is open for future fixes, right? Not sure I get this question. We have exports missing in EAL for some series posted on the ml waiting for merges. I suspect some recent merged changes have issues too (but did not check yet). This current patch does not address such issues and we need fixes afterwards if this is what you mean. -- David Marchand