From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Long Li <longli@microsoft.com>, Wei Hu <weh@microsoft.com>
Subject: Re: [PATCH] bus/vmbus: remove unnecessary packed attribute
Date: Wed, 30 Oct 2024 10:26:38 +0100 [thread overview]
Message-ID: <CAJFAV8xWDXBxF+Ja+QSiPoZ6zPaycZ0Exm+89C1fY273JMKx3Q@mail.gmail.com> (raw)
In-Reply-To: <20241022023728.451151-1-stephen@networkplumber.org>
On Tue, Oct 22, 2024 at 4:37 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The VMBus ring structure was marked packed which will cause
> warnings if the no-address-of-packed is enabled. The structure
> is all 32 bit values and the packed attribute has no impact
> on the code layout; remove it.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
- Why only clean this structure in this header?
I see many others which could get cleaned wrt __rte_packed.
(There are some unused structs too and it would be better not to keep
unused code around).
- On a separate note, I wonder why the vmbus headers are exported as
public headers.
All those seem to be for use only in drivers, for resources attached
on such a bus.
Would an application benefit from talking directly to the hyperv?
--
David Marchand
prev parent reply other threads:[~2024-10-30 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 2:37 Stephen Hemminger
2024-10-22 3:43 ` Wei Hu
2024-10-30 9:26 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xWDXBxF+Ja+QSiPoZ6zPaycZ0Exm+89C1fY273JMKx3Q@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=stephen@networkplumber.org \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).