* [PATCH] bus/vmbus: remove unnecessary packed attribute
@ 2024-10-22 2:37 Stephen Hemminger
2024-10-22 3:43 ` Wei Hu
2024-10-30 9:26 ` David Marchand
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2024-10-22 2:37 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Long Li, Wei Hu
The VMBus ring structure was marked packed which will cause
warnings if the no-address-of-packed is enabled. The structure
is all 32 bit values and the packed attribute has no impact
on the code layout; remove it.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/bus/vmbus/rte_vmbus_reg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/vmbus/rte_vmbus_reg.h b/drivers/bus/vmbus/rte_vmbus_reg.h
index e3299aa871..c4f2fa4c7e 100644
--- a/drivers/bus/vmbus/rte_vmbus_reg.h
+++ b/drivers/bus/vmbus/rte_vmbus_reg.h
@@ -108,7 +108,7 @@ struct vmbus_bufring {
* !!! DO NOT place any fields below this !!!
*/
uint8_t data[];
-} __rte_packed;
+};
/*
* Channel packets
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] bus/vmbus: remove unnecessary packed attribute
2024-10-22 2:37 [PATCH] bus/vmbus: remove unnecessary packed attribute Stephen Hemminger
@ 2024-10-22 3:43 ` Wei Hu
2024-10-30 9:26 ` David Marchand
1 sibling, 0 replies; 3+ messages in thread
From: Wei Hu @ 2024-10-22 3:43 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: Long Li
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, October 22, 2024 10:37 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Long Li
> <longli@microsoft.com>; Wei Hu <weh@microsoft.com>
> Subject: [PATCH] bus/vmbus: remove unnecessary packed attribute
>
> The VMBus ring structure was marked packed which will cause warnings if the
> no-address-of-packed is enabled. The structure is all 32 bit values and the
> packed attribute has no impact on the code layout; remove it.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/bus/vmbus/rte_vmbus_reg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/vmbus/rte_vmbus_reg.h
> b/drivers/bus/vmbus/rte_vmbus_reg.h
> index e3299aa871..c4f2fa4c7e 100644
> --- a/drivers/bus/vmbus/rte_vmbus_reg.h
> +++ b/drivers/bus/vmbus/rte_vmbus_reg.h
> @@ -108,7 +108,7 @@ struct vmbus_bufring {
> * !!! DO NOT place any fields below this !!!
> */
> uint8_t data[];
> -} __rte_packed;
> +};
>
> /*
> * Channel packets
> --
> 2.45.2
Reviewed-by: Wei Hu <weh@microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus/vmbus: remove unnecessary packed attribute
2024-10-22 2:37 [PATCH] bus/vmbus: remove unnecessary packed attribute Stephen Hemminger
2024-10-22 3:43 ` Wei Hu
@ 2024-10-30 9:26 ` David Marchand
1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2024-10-30 9:26 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Long Li, Wei Hu
On Tue, Oct 22, 2024 at 4:37 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The VMBus ring structure was marked packed which will cause
> warnings if the no-address-of-packed is enabled. The structure
> is all 32 bit values and the packed attribute has no impact
> on the code layout; remove it.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
- Why only clean this structure in this header?
I see many others which could get cleaned wrt __rte_packed.
(There are some unused structs too and it would be better not to keep
unused code around).
- On a separate note, I wonder why the vmbus headers are exported as
public headers.
All those seem to be for use only in drivers, for resources attached
on such a bus.
Would an application benefit from talking directly to the hyperv?
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-30 9:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-22 2:37 [PATCH] bus/vmbus: remove unnecessary packed attribute Stephen Hemminger
2024-10-22 3:43 ` Wei Hu
2024-10-30 9:26 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).