Re: [dpdk-dev] [PATCH] drivers: fix build issues with redundant newline changes

[David Marchand <david.marchand@redhat.com>]

Hello Jerin,

On Mon, Oct 7, 2024 at 10:13 AM <jerinj@marvell.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Certain section of the code in net/mvpp2 and ml/cnxk is enabled only
> when all depended library dependences where meet.
> Fixing those build errors.

Sorry for missing those.
Too bad there is no CI with such libraries installed.


>
> Fixes: e99981af3463 ("drivers: replace logging helpers")

I fixed other similar issues for ml/cnxk fixes in commit f665790a5dba
("drivers: remove redundant newline from logs").

net/mvpp2 was touched only with 2b843cac232e ("drivers: use per line
logging in helpers").
But the issues were present regardless of the changes in the logging macro.

In the end, I would rather flag this whole patch as:
Fixes: f665790a5dba ("drivers: remove redundant newline from logs").

>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>

Double checking manually, I think we are missing another small fix:

$ git diff
diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c
index 3e98cce099..e298da2724 100644
--- a/drivers/net/mvpp2/mrvl_qos.c
+++ b/drivers/net/mvpp2/mrvl_qos.c
@@ -972,7 +972,7 @@ setup_policer(struct mrvl_priv *priv, struct
pp2_cls_plcr_params *params)
         *
         * Lets use 0th then.
         */
-       sprintf(match, "policer-%d:%d\n", priv->pp_id, 0);
+       sprintf(match, "policer-%d:%d", priv->pp_id, 0);
        params->match = match;

        ret = pp2_cls_plcr_init(params, &priv->default_policer);


-- 
David Marchand