From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C066645AD2; Mon, 7 Oct 2024 10:40:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A56940ED8; Mon, 7 Oct 2024 10:40:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E262340E0B for ; Mon, 7 Oct 2024 10:40:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728290434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KBaut2CpbXSUX8NgIigS1I0xsgw+IOFpJnQCF7JAl2g=; b=T+cazubeKURv2VVQ9M3x7sw1WwKKjSM4eYhr1A4YLOuC/rdpg3Z5LRJFv9ZOd3akNhTxDt x4bY6tn6a0o7Ws1USuRmQ6dH49pmLovHoXGPSTKxWlW7dzjrwL5Rr+ckX26qn2UpwVdWOX cOUadkvQkLBP68c2julbttCFF2nBwYs= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-466-TXsV4fy7O4uNPg1m2kPkoQ-1; Mon, 07 Oct 2024 04:40:33 -0400 X-MC-Unique: TXsV4fy7O4uNPg1m2kPkoQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2fac57a3f02so34747471fa.1 for ; Mon, 07 Oct 2024 01:40:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728290432; x=1728895232; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KBaut2CpbXSUX8NgIigS1I0xsgw+IOFpJnQCF7JAl2g=; b=ufCCc00XuOyu28ydb2yPp4tnFzzIZzvVof/KIqFuo1p2R59N5HhrsoYblbatyFI9si S5P2LP0Qjot8RXQOTFAaq+cSGDZRiq+aWgmqAwWMcuCPxhM7OqQAPRgY+NO9yR4fyHVV 6lMP93NHqpyUgaNznXyNpcAKi+UmlzhbMs82iRxzRgHFE+LbYePO+/3Ze95nvwiY3Odr TvuZ03xchyQlQ1uJnXxOSBMhEGXmEp/YO/mjtYG4bXTe/OC3ysoS/tyKXf1NBLM0eMli xACR/gViDmKRp6QBF3yR0CcLB/Gt5tMP/07kTE8e74HMBvJhPLo4xFD+QP+sHGpCHx2x MCNw== X-Forwarded-Encrypted: i=1; AJvYcCX3XUnPN+EPsi8TKfV0uoUDZtvccaiEaIreoq2T68keotFWCCRdsOUzArLySVeYDxIiWIE=@dpdk.org X-Gm-Message-State: AOJu0YwhSD1Dna66sDZ80e5wEI9jrCfoyuZIkKYtE7bhqw9EAcolDuQG I7Ssv8k8Lj4UCTfS+JTDpGViDJPxK9cjXThtcKmsPDZUvp00YkCMY0FXvVEt3LYYBwq2oKt20T1 SdBZ/DWfluzuMaGRGkaXS5mIzy8p0st4dYCvBHxTwyfZJQyi/To/jp4rq6KRenkAjdXKQwylBEb X6vx4/2ptKOBl9OOg= X-Received: by 2002:a2e:510a:0:b0:2fa:f5b0:a8a0 with SMTP id 38308e7fff4ca-2faf5b0a99bmr34662921fa.41.1728290431700; Mon, 07 Oct 2024 01:40:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEB2p6UkRJ4RkePPWVh9b0JLSx3LvwnPMUhsqMctpqznZTnhj3SGytDV91b9g5cgfujcQFnHBsSmCScWH30I3Q= X-Received: by 2002:a2e:510a:0:b0:2fa:f5b0:a8a0 with SMTP id 38308e7fff4ca-2faf5b0a99bmr34662701fa.41.1728290431286; Mon, 07 Oct 2024 01:40:31 -0700 (PDT) MIME-Version: 1.0 References: <20241007081301.2999359-1-jerinj@marvell.com> In-Reply-To: <20241007081301.2999359-1-jerinj@marvell.com> From: David Marchand Date: Mon, 7 Oct 2024 10:40:20 +0200 Message-ID: Subject: Re: [dpdk-dev] [PATCH] drivers: fix build issues with redundant newline changes To: jerinj@marvell.com Cc: Srikanth Yalavarthi , Liron Himi , dev@dpdk.org, thomas@monjalon.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Jerin, On Mon, Oct 7, 2024 at 10:13=E2=80=AFAM wrote: > > From: Jerin Jacob > > Certain section of the code in net/mvpp2 and ml/cnxk is enabled only > when all depended library dependences where meet. > Fixing those build errors. Sorry for missing those. Too bad there is no CI with such libraries installed. > > Fixes: e99981af3463 ("drivers: replace logging helpers") I fixed other similar issues for ml/cnxk fixes in commit f665790a5dba ("drivers: remove redundant newline from logs"). net/mvpp2 was touched only with 2b843cac232e ("drivers: use per line logging in helpers"). But the issues were present regardless of the changes in the logging macro. In the end, I would rather flag this whole patch as: Fixes: f665790a5dba ("drivers: remove redundant newline from logs"). > > Signed-off-by: Jerin Jacob Double checking manually, I think we are missing another small fix: $ git diff diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index 3e98cce099..e298da2724 100644 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -972,7 +972,7 @@ setup_policer(struct mrvl_priv *priv, struct pp2_cls_plcr_params *params) * * Lets use 0th then. */ - sprintf(match, "policer-%d:%d\n", priv->pp_id, 0); + sprintf(match, "policer-%d:%d", priv->pp_id, 0); params->match =3D match; ret =3D pp2_cls_plcr_init(params, &priv->default_policer); --=20 David Marchand