From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76FC545F1E; Mon, 23 Dec 2024 09:45:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E52840263; Mon, 23 Dec 2024 09:45:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D238940156 for ; Mon, 23 Dec 2024 09:45:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734943522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fxn85cx5IqUo46aTATyD7aPVuQaW3cg+J38uEmLNbFc=; b=BRWfq6pVDU2taN/qnGKpCwU2KXN2eA0xOqM3Ke4mVEuyyACoFCjmUklU5b391Q89sZHyXm kizXX/h0RGHqQOmW/ueID2fqLRulxVXI703Hs/8sylCfZ5W3NvMwXe5jkniES+xPpaRYlQ pPQbky5+pBGXqy/MVaVVSQcvVJLfVSA= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-tu7tTimaMNSvxi65cusodA-1; Mon, 23 Dec 2024 03:45:21 -0500 X-MC-Unique: tu7tTimaMNSvxi65cusodA-1 X-Mimecast-MFC-AGG-ID: tu7tTimaMNSvxi65cusodA Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5401a22a82bso1993435e87.0 for ; Mon, 23 Dec 2024 00:45:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734943519; x=1735548319; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fxn85cx5IqUo46aTATyD7aPVuQaW3cg+J38uEmLNbFc=; b=vpmjRqfrCA+BgerUPfmHv+twwui8c5vGyiGoXg5nwHeEEchipLvIFjKk1u3n4ggVfS u6XeFWCbDL0AeasNvLq43NGGu0/AlTSki6Igj4uTeVFKJohtE5i+6Al9R46esoqBml4L W5M7Rd4wUFfHIOU31p7a9QnShyMrdOZjf5/ksLkjAPVofa9L4srkP4m/rshGJXEil4RW Q1qXIs4SDZWE4xu96TBCZg07XYaFnQRlBDdQcNUMaplNZmDTnVG+wAlg++wu70HONBMQ 0N4WNIsjgoeEj3/STmyuU2x7IXsjtkxsqmPPkd8GewRUE5DrdUB6G40HXTfaDG2suEF3 scyg== X-Gm-Message-State: AOJu0YyaS94RwLgMyNFjjTkhkrzwEufDsi0ppdjRSYCDDOZ4IYh7t1hK mn+sFaIHhpeRz+jvdUNfoYT5e9tgsrNevM8FdajcdIe2KN4epKxOsBqDCvSX4mgBURxBFjhAm/o oBucdtrsAbmkQgfCe85sCoLoGlC+SOOB3i4y3UmVfye6Ntbh4zWdBwzQ22xTc7amdLTfpNw5qI7 i3TBQ0QvFAiI4VDUE= X-Gm-Gg: ASbGncvtSjuK711gLiCoES1GYLjtBTVkC//pl04g9/Ohwx3NhVhzdX8yVIgOISVjNIS 4GwlIkncrTwkYHENtXd2Bph5tY3dB1MjYZwsqkSW/ X-Received: by 2002:a05:6512:ba4:b0:540:2a15:9b5d with SMTP id 2adb3069b0e04-54229561a38mr3131836e87.42.1734943519608; Mon, 23 Dec 2024 00:45:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmoO4DijR4rwOJhBcrh9ZFG1KOpBMXmKew1SVXZ4o4n8yPKDmVP31jB6MjeejKXqopG9PVQQ8gWxu2KlTUPqI= X-Received: by 2002:a05:6512:ba4:b0:540:2a15:9b5d with SMTP id 2adb3069b0e04-54229561a38mr3131827e87.42.1734943519219; Mon, 23 Dec 2024 00:45:19 -0800 (PST) MIME-Version: 1.0 References: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com> <1733954844-24397-1-git-send-email-andremue@linux.microsoft.com> <1733954844-24397-14-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1733954844-24397-14-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Mon, 23 Dec 2024 09:45:08 +0100 Message-ID: Subject: Re: [PATCH v2 13/14] drivers/raw: use portable variadic macros To: Andre Muezerie Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1I-EnJHFrF1iqkmrpjOP3IdFXUWoZsxnMQZbVoqlq4s_1734943520 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 11, 2024 at 11:08=E2=80=AFPM Andre Muezerie wrote: > > Many places are using a GCC extension related to variadic macros, > where a name prepends the ellipsis. This results in a warning like > the one below when compiling the code with MSVC: > > app\test-pmd\testpmd.h(1314): error C2608: > invalid token '...' in macro parameter list > > Variadic macros became a standard part of the C language with C99. > GCC, Clang and MSVC handle them properly. > > The fix is to remove the prefix name (args... becomes ...) and use > __VA_ARGS__. > > Signed-off-by: Andre Muezerie > --- > drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 24 +++++++++---------- > drivers/raw/ifpga/base/opae_debug.h | 4 ++-- > drivers/raw/ifpga/base/opae_osdep.h | 20 ++++++++-------- Touching osdep wrapper headers in base driver is ok, but not opae_debug.h as it is part of a base driver code. I'll drop the change on this file. > .../raw/ifpga/base/osdep_rte/osdep_generic.h | 4 ++-- > drivers/raw/ifpga/ifpga_rawdev.h | 16 ++++++------- > drivers/raw/skeleton/skeleton_rawdev.h | 16 ++++++------- > drivers/raw/skeleton/skeleton_rawdev_test.c | 8 +++---- > 7 files changed, 46 insertions(+), 46 deletions(-) --=20 David Marchand