From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org,
Wathsala Wathawana Vithanage <wathsala.vithanage@arm.com>,
Min Zhou <zhoumin@loongson.cn>,
David Christensen <drc@linux.ibm.com>,
Stanislaw Kardach <stanislaw.kardach@gmail.com>,
Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: Re: [PATCH] eal/x86: cache queried CPU flags
Date: Mon, 7 Oct 2024 13:23:05 +0200 [thread overview]
Message-ID: <CAJFAV8xX9HSvKzD_kufhz-qa7ssYBCEQ+MQnPvKDh3n5ivwhSg@mail.gmail.com> (raw)
In-Reply-To: <20241007110725.377550-1-bruce.richardson@intel.com>
On Mon, Oct 7, 2024 at 1:07 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Rather than re-querying the HW each time a CPU flag is requested, we can
> just save the return value in the flags array. This should speed up
> repeated querying of CPU flags, and provides a workaround for a reported
> issue where errors are seen with constant querying of the AVX-512 CPU
> flag from a non-AVX VM.
This could be applied to other arches cpuflag implementation.
Copying other arches maintainers as a fyi.
>
> Bugzilla Id: 1501
Bugzilla ID*
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
I did a quick pass, it lgtm.
--
David Marchand
next prev parent reply other threads:[~2024-10-07 11:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 11:06 Bruce Richardson
2024-10-07 11:23 ` David Marchand [this message]
2024-10-07 14:47 ` Wathsala Wathawana Vithanage
2024-10-07 16:29 ` Wathsala Wathawana Vithanage
2024-10-07 16:43 ` Bruce Richardson
2024-10-07 17:30 ` Wathsala Wathawana Vithanage
2024-10-11 12:42 ` Konstantin Ananyev
2024-10-11 12:48 ` Bruce Richardson
2024-10-11 13:00 ` Konstantin Ananyev
2024-10-11 13:31 ` Bruce Richardson
2024-10-11 13:33 ` [PATCH v2] " Bruce Richardson
2024-10-11 13:37 ` Konstantin Ananyev
2024-10-14 18:29 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xX9HSvKzD_kufhz-qa7ssYBCEQ+MQnPvKDh3n5ivwhSg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.ibm.com \
--cc=konstantin.ananyev@huawei.com \
--cc=stanislaw.kardach@gmail.com \
--cc=wathsala.vithanage@arm.com \
--cc=zhoumin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).