From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98EF845AD7; Mon, 7 Oct 2024 13:23:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FF63402EA; Mon, 7 Oct 2024 13:23:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 19A274026C for ; Mon, 7 Oct 2024 13:23:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728300200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ronIODxj1udjdbhIcf6hnC30vTpgBSaWRlKijzgQ4oE=; b=Q6MUhZ5YRcMBQNWFWNsRbEws++MADV+538NT4yWw1a2QtsbAViCDymYLJj1nKrBwxVETq0 ALkVNK094DlZdvuNsc4O+TIkrXXaA9gUQ+abpuP/mHm2n2S1o67qxlLZUyhhG5XynXGosp vKAPn4t1lSA0hNllXwtOUmJ7UphmpbE= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-cNcE2-YOONSVCRgHbEzzlg-1; Mon, 07 Oct 2024 07:23:19 -0400 X-MC-Unique: cNcE2-YOONSVCRgHbEzzlg-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-539a078aaf2so3744704e87.1 for ; Mon, 07 Oct 2024 04:23:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728300198; x=1728904998; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ronIODxj1udjdbhIcf6hnC30vTpgBSaWRlKijzgQ4oE=; b=cZJZeNZugg6Hcdd2WDX4cRXeAyWHDNyq9EC0NGOTI3ftzwZ44Z5R30nqXQdLZB2P/z BFO9GKLSoQalIb1Gpz22VbFHhD7cKDH1Qgw4H4MWtzGetkBKg5K2V3IxU+tFzvK/HVUm ZasKc2Zscfz8UjSmI5hS5uxjmYOHJyfzTAhuojqrdKRnIQnBUDTA1JlpDAGHhA4QCkAB scK1SAiwA7gLsTxXpsPLo8ia2TK0pUmsrO+vkUbx8a+NCMasJoy/PP4E8WdMZhR7PD8N TqE0EJE2WnIdc6ES8NVLRPkCoCRmVwfgfdItfJZdtwPVl1LKQuV7v7FEtRuJaLHY0gDp 0vSg== X-Gm-Message-State: AOJu0YyigNTIKtwHqONHK5zh1SVS3T8MyxLyban7p8pgAG4ksMLJVWHf ZJ1x0/zVxwS94u8hm4br53ww1O31dtlB/Z44An8hxoy8lMGivs98QLXpov9XUpILrZ+OiDo9+4o xCapGxaJ7IEbuKMk/tr+saVEE6gksLNlEDGkZjEEBTw6gi3Yc7PDiQ1MO9DE9xM47mc7VF+JVGX OGLl6J9pSTpXSpTJs= X-Received: by 2002:a05:6512:3d0c:b0:533:d3e:16f5 with SMTP id 2adb3069b0e04-539ab9cf3cemr5433481e87.38.1728300197908; Mon, 07 Oct 2024 04:23:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKp4Q4BShIdVR0+6iBaus6km7GUGb3n44i694aM5DxHpQF7SxbbeuRCjL5EvZr7TsQ5PoCDuUhpizhmqE+b64= X-Received: by 2002:a05:6512:3d0c:b0:533:d3e:16f5 with SMTP id 2adb3069b0e04-539ab9cf3cemr5433462e87.38.1728300197491; Mon, 07 Oct 2024 04:23:17 -0700 (PDT) MIME-Version: 1.0 References: <20241007110725.377550-1-bruce.richardson@intel.com> In-Reply-To: <20241007110725.377550-1-bruce.richardson@intel.com> From: David Marchand Date: Mon, 7 Oct 2024 13:23:05 +0200 Message-ID: Subject: Re: [PATCH] eal/x86: cache queried CPU flags To: Bruce Richardson Cc: dev@dpdk.org, Wathsala Wathawana Vithanage , Min Zhou , David Christensen , Stanislaw Kardach , Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 7, 2024 at 1:07=E2=80=AFPM Bruce Richardson wrote: > > Rather than re-querying the HW each time a CPU flag is requested, we can > just save the return value in the flags array. This should speed up > repeated querying of CPU flags, and provides a workaround for a reported > issue where errors are seen with constant querying of the AVX-512 CPU > flag from a non-AVX VM. This could be applied to other arches cpuflag implementation. Copying other arches maintainers as a fyi. > > Bugzilla Id: 1501 Bugzilla ID* > > Signed-off-by: Bruce Richardson I did a quick pass, it lgtm. --=20 David Marchand