From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED2FD4374A; Wed, 20 Dec 2023 15:00:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B43140A89; Wed, 20 Dec 2023 15:00:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 22793402DD for ; Wed, 20 Dec 2023 15:00:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703080824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dUFNNhtPzFBv1c04QIZc6dEsyHcIRjjNdKBZ75/Zkw8=; b=fdmPH9CyA+MU5uv8AlqbwEtTwNmE22XcXXt//xxypNPxKwAlDy+h7BKYBj24SJokGTBEoV jbvdOSCUif5VHjm/4RuKTP/hxZrOtNNbEi/f0P8Jnxi44TPCsYo3i1djJM84jgklXIjKkZ OPIkbaIk1JI4OgwZVR7Hnwe06NBqqh0= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-njnGF1RiP5-S_X7dm2YbWQ-1; Wed, 20 Dec 2023 09:00:23 -0500 X-MC-Unique: njnGF1RiP5-S_X7dm2YbWQ-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-50e449660e4so1689315e87.0 for ; Wed, 20 Dec 2023 06:00:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703080821; x=1703685621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dUFNNhtPzFBv1c04QIZc6dEsyHcIRjjNdKBZ75/Zkw8=; b=LYISuHglVPl5ianlJiqnClP/KMZEG57ub5mPoZWUgTUV8ldTXlhfHQPZBtvNgmzM9C mP6F1ZaZKt0NYmv7BFuy8RveaQIPDGqqUGKEfYt61LXYK/MdwC/5NY9sV1B2f8pPSqvu 9SXVgBOC3otT23nG29DSuaoWRjEYUk64eqDvWpU3ht9ce1PqVuOFlToSCaTrg/q3UC9S Nlsfng/NUn8s9jzaa00L9roA00sSSyYgtySJeqB0bcXoRPbEvgc5XeMjjUd5h/OZhKp1 iUgSWOgaYXlT4o3Ee5f9F+fUhlQ4yFTBi8bw4x9Hh7icgZoYNJTZkeVDN1G+RMwMuJKM GhkQ== X-Gm-Message-State: AOJu0YzG3aP23QhmgE9UkVZXFkrCMV8txVPU4XWr0vURMDH5Fz3qiEWT tpfFIyjPTOiuXF1bqxcx75yqw2+2piZ37lf7EIPdnL+LfLq4zkijl7+SXDMEuZSvs0xIRZGOzW5 gZZ2OI5UAjhGVGk8PjG0= X-Received: by 2002:a05:6512:2096:b0:50e:24a4:bbc3 with SMTP id t22-20020a056512209600b0050e24a4bbc3mr2458914lfr.116.1703080821565; Wed, 20 Dec 2023 06:00:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IElchJFkqBcg22eaFkX8r/eURjwzd9kG7IYXA+zB2Gl/3an5xkvaX1bBcFm2DKVUbiqHCGT4XGJRENiBzjG+N4= X-Received: by 2002:a05:6512:2096:b0:50e:24a4:bbc3 with SMTP id t22-20020a056512209600b0050e24a4bbc3mr2458885lfr.116.1703080821186; Wed, 20 Dec 2023 06:00:21 -0800 (PST) MIME-Version: 1.0 References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231218143805.1500121-1-david.marchand@redhat.com> <20231218143805.1500121-13-david.marchand@redhat.com> <3800186.q0ZmV6gNhb@thomas> In-Reply-To: <3800186.q0ZmV6gNhb@thomas> From: David Marchand Date: Wed, 20 Dec 2023 15:00:09 +0100 Message-ID: Subject: Re: [PATCH v4 12/14] lib: convert to per line logging To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, Andrew Rybchenko , Konstantin Ananyev , Anatoly Burakov , Harman Kalra , Jerin Jacob , Sunil Kumar Kori , Harry van Haaren , Stanislaw Kardach , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Byron Marohn , Yipeng Wang , Vladimir Medvedkin , Sameh Gobriel , Reshma Pattan , Cristian Dumitrescu , David Hunt , Sivaprasad Tummala , Honnappa Nagarahalli , Volodymyr Fialko , Maxime Coquelin , Chenbo Xia X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 20, 2023 at 2:46=E2=80=AFPM Thomas Monjalon wrote: > > 18/12/2023 15:38, David Marchand: > > Convert many libraries that call RTE_LOG(... "\n", ...) to RTE_LOG_LINE= . > > > > Note: > > - for acl and sched libraries that still has some debug multilines > > messages, a direct call to RTE_LOG is used: this will make it easier = to > > notice such special cases, > > [...] > > 129 files changed, 2280 insertions(+), 2279 deletions(-) > > It would be nice to keep RTE_LOG() only for multi-line as you do, > and use RTE_LOG_LINE only in wrapper macros specific per library. > This patch is using RTE_LOG_LINE directly in multiple places > in libraries which do not have a dedicated wrapper macro. > Would it be possible to introduce new wrappers for these libraries > in this patch? It is doable and not too difficult to achieve with some scripting. I'll try in the v5 (since I need to send a new revision for build with -pedantic). --=20 David Marchand