From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DDAA41D30; Tue, 21 Feb 2023 16:02:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6684431F4; Tue, 21 Feb 2023 16:02:28 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BF70540E0F for ; Tue, 21 Feb 2023 16:02:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676991747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9Re6V507uvZkd7mw+ijXkIV5PKFhB6s+3gPcImJZkCY=; b=ixPgMvwgR/I+d5hkeLTJmAIwPLOvvUcT9kXkF5dNsQfWGMYmYQttalcRYH4vd3E5o8IqzQ Q7o6rcmcCAvEKiYi8rm738W7kxLpR5Ywelx2NhPFFcJeCSb/AhdKVP+/3heIkErMwmwkt1 Ox19Mq2bE6ara5IinvQqcE/ijV6mHSk= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-399-_gw9IuPUOter--amCaymGw-1; Tue, 21 Feb 2023 10:02:21 -0500 X-MC-Unique: _gw9IuPUOter--amCaymGw-1 Received: by mail-pg1-f199.google.com with SMTP id f11-20020a6547cb000000b00502d7714305so891370pgs.13 for ; Tue, 21 Feb 2023 07:02:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9Re6V507uvZkd7mw+ijXkIV5PKFhB6s+3gPcImJZkCY=; b=4DAIZANA7vgDG7gsRPv2wboSIl5u0y5PADSjcn7DFwCojL9ZHl6hAOjiG+BY5QuPCW NrSxzgT/cqI2UCZTVAqpYt4pbN59PUCZNqhnS16AnIe7QllP/NEbZ8/VxJmhFaIwrh4/ gVmMk94szE2CKJnbfs/uQ/7XqxxwrC6YlzZZKhmOVfP9ChMpJeuK9NYGptdoIFJsqMdS H/p7We/xiJMnz8KXV5gALyv+sZkJ6q6GwdJxZ5ciIpbx7XJncC5gOj3YTnMBXthuFy+J t1LZTcK0YcrTXUFyXg2FJkGpi/ZA7w03luoSTm+zj6RxLXlB8Zh6O41GMWrInJQDMk4M i6dA== X-Gm-Message-State: AO0yUKVDMtC2OGpDH00FtePeAWiPa23RMPbH8sX2IuTbhoMzxyMzZjFy FBUAhmXjYxeLkTeSwGibvmHO3B6BQ2MRzPWpayOdkavaHpjhYlZY+3paVy+NeRBsjovJHCTIakS F6vhzfJRInjJ5KqWKHUE= X-Received: by 2002:a17:90b:3912:b0:233:f53f:95eb with SMTP id ob18-20020a17090b391200b00233f53f95ebmr1557883pjb.51.1676991739952; Tue, 21 Feb 2023 07:02:19 -0800 (PST) X-Google-Smtp-Source: AK7set8ExFlAtqVe8AX0bF5vATpLUpN3zC0JOj/B+ZNfdfZAsfc0LZM+zMzVlcP6PVrdXFoqMQ4B/PeWcyOUWH2A3S8= X-Received: by 2002:a17:90b:3912:b0:233:f53f:95eb with SMTP id ob18-20020a17090b391200b00233f53f95ebmr1557872pjb.51.1676991739550; Tue, 21 Feb 2023 07:02:19 -0800 (PST) MIME-Version: 1.0 References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230220233556.168553-1-stephen@networkplumber.org> <20230220233556.168553-22-stephen@networkplumber.org> In-Reply-To: <20230220233556.168553-22-stephen@networkplumber.org> From: David Marchand Date: Tue, 21 Feb 2023 16:02:08 +0100 Message-ID: Subject: Re: [PATCH v8 21/22] hash: move rte_hash_set_alg out header To: Stephen Hemminger Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 21, 2023 at 12:38 AM Stephen Hemminger wrote: > > The code for setting algorithm for hash is not at all perf sensitive, > and doing it inline has a couple of problems. First, it means that if > multiple files include the header, then the initialization gets done > multiple times. But also, it makes it harder to fix usage of RTE_LOG(). > > Despite what the checking script say. This is not an ABI change, the > previous version inlined the same code; therefore both old and new code > will work the same. I suppose you are referring to: http://mails.dpdk.org/archives/test-report/2023-February/356872.html ERROR: symbol rte_hash_crc_set_alg is added in the DPDK_23 section, but is expected to be added in the EXPERIMENTAL section of the version map I agree that this is irrelevant and can be ignored in this particular case. -- David Marchand