From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1FBAA2EEB for ; Mon, 7 Oct 2019 16:00:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58D571C1F9; Mon, 7 Oct 2019 16:00:23 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 8EFF11C1F8 for ; Mon, 7 Oct 2019 16:00:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570456821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tCuWuaDc87Qt/g0PelSU+SZsxH1rofPX4zD9Ek8tYR4=; b=gygAS/NaTkYwUZx3MMfU8BKv0SXSd77GlsFJYMjplAIhBhf+FOc2WaucSLZt5hKWGjWSS6 6uY/WUr8K9/mz2HH3NZ8B6D9X64cDzurhbLd3L2nn3w6xAI6ncJq9hMGNxMnxTJgF5CgwV h5wi2uKhgSkw8zD6C+Tt+tvcdHEsx54= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-4_MK5QnEOhW4KCNEEH8jVA-1; Mon, 07 Oct 2019 10:00:17 -0400 Received: by mail-vk1-f200.google.com with SMTP id h186so6840629vkg.14 for ; Mon, 07 Oct 2019 07:00:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F5YpD/t6AbStyqt5pFy2ZogKKJlKrBSXQfbgQMspRDc=; b=bXjSsLeUnwAsKcZOZfFpKd9Kbzq6WCvhuARSs6pmetGkNeJWBHIqDCXHIyZ6q1ZPE1 HPpBkq3UoOXr7gfV641DUd0SvyjT/DhIw9rE+ApWgrH2RJqUHcflgIQoemLSDmfwjb3r Spt73c1O1aS1GzxaUzN0Lf1b8QCAph/XIbXB4xbneZbyMzX9bUH7lkZyOC11HaXZmJ1l syc11ZVN1KXdkoTN0uywYIJojWY5QcqsAHhDZJZgBQxVKO3UZscQbWKfv4cz7bdQO54L 2GPVThegVi6nqytbuJ0rQ8SN3J8Qk7l1COqiwpOaE9/3ccdkbayqzNi9at4nOakv4FWp NfiQ== X-Gm-Message-State: APjAAAXKaezpWGz2AS4OtNODzQ8nUbHp8dONe54zkcXTvIpndHMiqIy3 iDnKfZ8qMUuGW699wK6/cpCFYk+CIODGt3LIGe7v345J1w4erzWhPaR1P3keOfYA2WGgUWZMSnl 2xwE0+wSLDtR8J1+dtB0= X-Received: by 2002:ac5:c911:: with SMTP id t17mr4653500vkl.56.1570456817229; Mon, 07 Oct 2019 07:00:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqxM0XuTMVGTDKMpaKh7L9Sd9hObZTB7XzSzXcuIU/WzvaEkn9VBPKJLJt0o5HzWrSpV0mh41wIFcYK68hYPgxk= X-Received: by 2002:ac5:c911:: with SMTP id t17mr4653482vkl.56.1570456816793; Mon, 07 Oct 2019 07:00:16 -0700 (PDT) MIME-Version: 1.0 References: <20190908224949.34851-1-honnappa.nagarahalli@arm.com> <20190908224949.34851-5-honnappa.nagarahalli@arm.com> In-Reply-To: From: David Marchand Date: Mon, 7 Oct 2019 16:00:05 +0200 Message-ID: To: Honnappa Nagarahalli Cc: "konstantin.ananyev@intel.com" , "dev@dpdk.org" , "stable@dpdk.org" , nd , "Ruifeng Wang (Arm Technology China)" X-MC-Unique: 4_MK5QnEOhW4KCNEEH8jVA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 4/7] test/rcu: use size_t instead of int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Honnappa, On Mon, Sep 9, 2019 at 5:17 PM Ruifeng Wang (Arm Technology China) wrote: > > > > -----Original Message----- > > From: dev On Behalf Of Honnappa Nagarahalli > > Sent: Monday, September 9, 2019 06:50 > > To: Honnappa Nagarahalli ; > > konstantin.ananyev@intel.com > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH 4/7] test/rcu: use size_t instead of int > > > > Variables used to store the return value of rte_rcu_qsbr_get_memsize in > > variables of type 'int'. The variables are of type 'size_t' now. > > > > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") > > Cc: stable@dpdk.org > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Gavin Hu > > --- > > app/test/test_rcu_qsbr_perf.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/app/test/test_rcu_qsbr_perf.c b/app/test/test_rcu_qsbr_per= f.c > > index cb2d177b7..e0598614c 100644 > > --- a/app/test/test_rcu_qsbr_perf.c > > +++ b/app/test/test_rcu_qsbr_perf.c > > @@ -125,7 +125,7 @@ test_rcu_qsbr_writer_perf(void *arg) static int > > test_rcu_qsbr_perf(void) > > { > > - int sz; > > + size_t sz; > > unsigned int i, tmp_num_cores; > > > > writer_done =3D 0; > > @@ -188,7 +188,7 @@ test_rcu_qsbr_perf(void) static int > > test_rcu_qsbr_rperf(void) > > { > > - int sz; > > + size_t sz; > > unsigned int i, tmp_num_cores; > > > > rte_atomic64_clear(&updates); > > @@ -234,7 +234,7 @@ test_rcu_qsbr_rperf(void) static int > > test_rcu_qsbr_wperf(void) > > { > > - int sz; > > + size_t sz; > > unsigned int i; > > > > rte_atomic64_clear(&checks); > > @@ -379,7 +379,7 @@ static int > > test_rcu_qsbr_sw_sv_1qs(void) > > { > > uint64_t token, begin, cycles; > > - int sz; > > + size_t sz; > > unsigned int i, j, tmp_num_cores; > > int32_t pos; > > > > -- > > 2.17.1 > > The same change is needed by test_rcu_qsbr_sw_sv_1qs_non_blocking. > And there are another 2 occurrences in test_rcu_qsbr.c. Ruifeng comment looks valid, can you have a look and submit a new version of this patch? Thanks. --=20 David Marchand