From: David Marchand <david.marchand@redhat.com>
To: fengchengwen <fengchengwen@huawei.com>
Cc: thomas@monjalon.net, stephen@networkplumber.org, dev@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v5 0/5] add semicolon when export any symbol
Date: Mon, 8 Sep 2025 09:54:09 +0200 [thread overview]
Message-ID: <CAJFAV8xY-hNK2yYoo7_KD5TAOxgPJt4RkR+kRnHDNh1jYuTHTQ@mail.gmail.com> (raw)
In-Reply-To: <abd687d3-acb9-4692-98a4-73ec03154efe@huawei.com>
Hello,
On Thu, 4 Sept 2025 at 02:24, fengchengwen <fengchengwen@huawei.com> wrote:
> On 9/3/2025 3:04 PM, David Marchand wrote:
> > The current positionning should be seen as an additional info on the
> > return type, in the definition of the symbol.
> > Does it mean that this IDE would fail if we add any kind of
> > macros/attribute involving the symbol name?
>
> I tried vscode and SI (source insight), and found user could use "token macro" in SI
> to make the IDE skip such symbol (so use ctrl+ will quick jump to definition), but
> I can't find such setting for vscode.
I asked someone who is more familiar with vscode than me (though she
is not used to C language).
Out of the box, this IDE could not understand C language, so she
installed the C/C++ extension pack (version 1.3.1, on some Ubuntu).
And it seems the symbols are correctly found with current main branch.
For example, opening only testpmd.c, rte_eal_init() mouse over shows
the header content.
In the same context, ctrl+clicking on rte_eal_init() in testpmd.c
proposes to open lib/eal/linux/eal.c, with the focus on the symbol
itself (and the RTE_EXPORT_SYMBOL macro is skipped).
Are you trying something different?
> >
> > Afaics, ctags can be taught to skip those macros and just behaves
> > correctly by adding in its config file:
> > -DRTE_EXPORT_EXPERIMENTAL_SYMBOL(a)=
> > -DRTE_EXPORT_INTERNAL_SYMBOL(a)=
> > -DRTE_EXPORT_SYMBOL(a)=
>
> How about add note in DPDK document if don't apply this commit?
We can add a generic mention that it might be necessary to configure
the IDE, and give an example for ctags.
--
David Marchand
next prev parent reply other threads:[~2025-09-08 7:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 2:59 [PATCH] dpdk: support quick jump to API definition Chengwen Feng
2025-08-29 2:34 ` [PATCH v2 0/3] " Chengwen Feng
2025-08-29 2:34 ` [PATCH v2 1/3] lib: " Chengwen Feng
2025-08-29 2:34 ` [PATCH v2 2/3] drivers: " Chengwen Feng
2025-08-29 2:34 ` [PATCH v2 3/3] doc: update ABI versioning guide Chengwen Feng
2025-09-01 1:21 ` [PATCH v3 0/5] add semicolon when export any symbol Chengwen Feng
2025-09-01 1:21 ` [PATCH v3 1/5] lib: add semicolon when export symbol Chengwen Feng
2025-09-01 1:21 ` [PATCH v3 2/5] lib: add semicolon when export experimental symbol Chengwen Feng
2025-09-06 4:14 ` Stephen Hemminger
2025-09-01 1:21 ` [PATCH v3 3/5] lib: add semicolon when export internal symbol Chengwen Feng
2025-09-01 1:21 ` [PATCH v3 4/5] drivers: add semicolon when export any symbol Chengwen Feng
2025-09-01 1:21 ` [PATCH v3 5/5] doc: update ABI versioning guide Chengwen Feng
2025-09-01 10:46 ` [PATCH v4 0/5] add semicolon when export any symbol Chengwen Feng
2025-09-01 10:46 ` [PATCH v4 1/5] lib: add semicolon when export symbol Chengwen Feng
2025-09-01 10:46 ` [PATCH v4 2/5] lib: add semicolon when export experimental symbol Chengwen Feng
2025-09-01 10:46 ` [PATCH v4 3/5] lib: add semicolon when export internal symbol Chengwen Feng
2025-09-01 10:46 ` [PATCH v4 4/5] drivers: add semicolon when export any symbol Chengwen Feng
2025-09-01 10:46 ` [PATCH v4 5/5] doc: update ABI versioning guide Chengwen Feng
2025-09-03 2:05 ` [PATCH v5 0/5] add semicolon when export any symbol Chengwen Feng
2025-09-03 2:05 ` [PATCH v5 1/5] lib: add semicolon when export symbol Chengwen Feng
2025-09-03 2:05 ` [PATCH v5 2/5] lib: add semicolon when export experimental symbol Chengwen Feng
2025-09-03 2:05 ` [PATCH v5 3/5] lib: add semicolon when export internal symbol Chengwen Feng
2025-09-03 2:05 ` [PATCH v5 4/5] drivers: add semicolon when export any symbol Chengwen Feng
2025-09-03 2:05 ` [PATCH v5 5/5] doc: update ABI versioning guide Chengwen Feng
2025-09-03 7:04 ` [PATCH v5 0/5] add semicolon when export any symbol David Marchand
2025-09-04 0:24 ` fengchengwen
2025-09-08 7:54 ` David Marchand [this message]
2025-09-08 12:43 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xY-hNK2yYoo7_KD5TAOxgPJt4RkR+kRnHDNh1jYuTHTQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).