From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B441443206; Thu, 26 Oct 2023 10:43:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A27AF427E6; Thu, 26 Oct 2023 10:43:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B4688402E9 for ; Thu, 26 Oct 2023 10:43:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698309806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mOt/FgUT9Ut7AsHf7VuOo1EpByh6gDSjV0hwUfMvsYw=; b=LWSuu1xyvSLWpwTcmPGvfH1SESvlPcXMz9TlUA88NGCXJ+cWJRsalEAkW54abDq17rJf1o ybpY68o3R54Q62WcRE901HSBTVKFxJqMPD9xzccayF4qYZa5It8oHFa0hHO1jIZhZP+k35 EDKRuJ0P8C/JuYbFYRP+Ps2hV+jk9AI= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-zptMHwt_NV-4zuJrdPg7ig-1; Thu, 26 Oct 2023 04:43:24 -0400 X-MC-Unique: zptMHwt_NV-4zuJrdPg7ig-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c51e44a4dbso6676651fa.3 for ; Thu, 26 Oct 2023 01:43:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698309803; x=1698914603; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mOt/FgUT9Ut7AsHf7VuOo1EpByh6gDSjV0hwUfMvsYw=; b=wqjb3ai9ot1uUMwzVu0eByHjSekiEt6QC/ljP+1bg68oKHoHixRaXCUqa6RMhhQW2K uWDytdv+XMyZ7LxabbFoNAPL0J0HZmTSgCN6Vrczz47CXP24SVeuEDmJVbFYSTqFPlw/ aVArzVMt7Nk2028+gSkJHSX55R6YNcITzi7GTnF3FzePnFHOEGozU8Nb17l+0iYeldWm thQeT8sew7sN0+TmnE/IsLxevomEAKVeKj1QyfHNx3CjTWX5oaY87qOhRGProgTEuSod WL0gCmtLlbCpTciiXp3qP9JD7YjRQmWyVGUYn4NePO6tRGqxAb1hf2617iGGAJdn4FBD 1zAw== X-Gm-Message-State: AOJu0YwQ/SbGDpHx4nHWO9MYvQ7o1jhdPUk8T/xPY+FFrEAhJ+JsV4X6 Aok18ME0+LNsgeJRds+RwdePZDSILb1w2PzULMIZYE4wjyYvvF1B9gLDBVnZF4ZtVFX4YkDqEPy E8K0DoIkA+EKew5F6pp4= X-Received: by 2002:a2e:b896:0:b0:2c5:1045:71cb with SMTP id r22-20020a2eb896000000b002c5104571cbmr12522891ljp.32.1698309803491; Thu, 26 Oct 2023 01:43:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHY9U6qVLS+ClR3KfEUhVgu3ly47BkEhmCTeryeL7yNMoJL4Wrhklv6WDeE4mb/JL2tShmSrq/YjJYds7hYR/4= X-Received: by 2002:a2e:b896:0:b0:2c5:1045:71cb with SMTP id r22-20020a2eb896000000b002c5104571cbmr12522882ljp.32.1698309803215; Thu, 26 Oct 2023 01:43:23 -0700 (PDT) MIME-Version: 1.0 References: <1697551570-20942-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1697551570-20942-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Thu, 26 Oct 2023 10:43:11 +0200 Message-ID: Subject: Re: [PATCH] eal: fix compile failure of asm on MSVC toolchain To: Tyler Retzlaff Cc: dev@dpdk.org, Anatoly Burakov , Bruce Richardson , Konstantin Ananyev , Sivaprasad Tummala X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 17, 2023 at 4:06=E2=80=AFPM Tyler Retzlaff wrote: > > Most MSVC targets do not support inline asm and __MWAITX__ is a GCC > implementation detail. Use a test of defined(RTE_TOOLCHAIN_MSVC) to > avoid conditional compilation of inline asm and instead use intrinsics > instead. > > Fixes: c7ed1ce04704 ("eal/x86: add power intrinsics for AMD") > > Signed-off-by: Tyler Retzlaff Acked-by: David Marchand Applied, thanks. --=20 David Marchand