From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AC1AA09FF; Tue, 5 Jan 2021 22:17:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 554701607FA; Tue, 5 Jan 2021 22:17:02 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 2EBFA1607A1 for ; Tue, 5 Jan 2021 22:17:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609881420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lcL7+KGa8mAQJPi0ApwwUFbmZfUFzLhSOu2c7CV/6Fo=; b=DGfMwR1dBBcZs7b+KMHyXGxDZ25SrAIURg9gkR+PlJRL7z1mwlYcPdPm2deIvflHCPiCv5 9PbnytP+p293gIrENOaa4DJB2pXovOVLMo0oNVezRXB0cu8feLYG1fEvZBwr+0D4dfTSh0 2Foo0E0TwSW40WNTMAXF3vwgOu8E/+E= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-5K89OAH7Pv-Jx52JayqPXw-1; Tue, 05 Jan 2021 16:16:59 -0500 X-MC-Unique: 5K89OAH7Pv-Jx52JayqPXw-1 Received: by mail-vk1-f199.google.com with SMTP id p184so500463vkd.18 for ; Tue, 05 Jan 2021 13:16:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lcL7+KGa8mAQJPi0ApwwUFbmZfUFzLhSOu2c7CV/6Fo=; b=RrDg9aMcnxUILKOg4mnXkiXOZ4KZ0QJaFyjoNgIYZ8NW9ue1b5wHJt3w7tR/Ce+YGn TCzIh4spm6wdFLtl7oE4+wDneauNlYTqxW0VGz+Wg4iOZESKzkLLum0oYpJZBO5TKcRa TmlRiTbeAm7pVn5ngbWJRRP0NwKcwpKvohmhh4WEZJy9pH+EqahUbHEDt+jY+B0g316F txoTw3ThxB0MCKMcZ0CRIx4teLGNUp8tnwPfjDdqJX9f7uZFQCMjrlZZH+gRs5aJA1CH fUGBdH+w6TVei1dmUg+34vnBGHC5rTtGVRqjF8ATkaTMLypZ5kqIGSw9xxdYl9tw+UjS 8BCA== X-Gm-Message-State: AOAM530Ot/U9SeomYn9jsrexZU3c1tdQJd6+3V6c7KWkBUEJEkjhVEA8 ozBhzueEcCuSKQdv8KMNPLuHq7A0xlVfRWDFymgZfoZukgkKtiUU7sfnJVDaS42lTuPin8Cnc54 p4RqOErjfvXYkrM81Pmk= X-Received: by 2002:a67:3212:: with SMTP id y18mr993959vsy.5.1609881418773; Tue, 05 Jan 2021 13:16:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJx/cIUF+o2z09gPsISUx9m08A3E/fFLQNv8ynNpYV/0kjHYKw3cA/zo8qNjwoBV4xvEJXBrcvpPC6UvjxvgDYY= X-Received: by 2002:a67:3212:: with SMTP id y18mr993956vsy.5.1609881418600; Tue, 05 Jan 2021 13:16:58 -0800 (PST) MIME-Version: 1.0 References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-5-maxime.coquelin@redhat.com> In-Reply-To: <20201220211405.313012-5-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 5 Jan 2021 22:16:47 +0100 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin wrote: > > This patch initiate refactoring of Virtio PCI, by introducing > a new device structure for PCI-specific metadata. This works, but this patch seems artificial. The eth_virtio_dev_init expects dev->data->dev_private to be a virtio_hw object. You can introduce this later in the series when really needed. -- David Marchand